[AI] Replace function role is replace by user for gemini 3.5 - #1871
Merged
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request changes the role for function responses from "function" to "user" in both streaming and non-streaming chat message calls within FunctionCallingViewModel.swift. Feedback indicates that this change violates the Gemini API contract, which requires function responses to be sent with the "function" (or "tool") role, and suggests reverting these changes to prevent API validation errors.
cynthiajoan
approved these changes
Sep 12, 2026
andrewheard
approved these changes
Sep 14, 2026
andrewheard
left a comment
andrewheard
left a comment
Contributor
There was a problem hiding this comment.
For additional context, firebase/firebase-ios-sdk#16478.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.