Skip to content

[build-tools] pass the website origin to serve-sim - #4437

Open
gwdp wants to merge 3 commits into
mainfrom
gwdp/serve-sim-cors-origin
Open

gwdp wants to merge 3 commits into
mainfrom
gwdp/serve-sim-cors-origin

Conversation

@gwdp

@gwdp gwdp commented Sep 17, 2026

Copy link
Copy Markdown
Contributor

Why

serve-sim needs to know which expo.dev origin may call it and frame it. We passed the CORS origin through the EAS_SIMULATOR_METRICS_CORS_ORIGIN env var and the frame ancestor from websiteOrigin(env)

How

Test Plan

CI

@codecov

codecov Bot commented Sep 17, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.41%. Comparing base (1672bcd) to head (b83f4df).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4437      +/-   ##
==========================================
- Coverage   72.41%   72.41%   -0.00%     
==========================================
  Files         972      972              
  Lines       46319    46317       -2     
  Branches     9954     9953       -1     
==========================================
- Hits        33537    33535       -2     
  Misses      11787    11787              
  Partials      995      995              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@gwdp
gwdp force-pushed the gwdp/serve-sim-cors-origin branch from df9b557 to 3baaec8 Compare September 17, 2026 22:59
@linear-code

linear-code Bot commented Sep 17, 2026

Copy link
Copy Markdown

ENG-26861

@gwdp
gwdp force-pushed the gwdp/serve-sim-cors-origin branch from 902f170 to 139b39c Compare September 18, 2026 00:12
Comment thread packages/build-tools/src/steps/utils/remoteDeviceRunSession.ts Outdated
@gwdp
gwdp force-pushed the gwdp/serve-sim-cors-origin branch from 04d134c to 014a9a4 Compare September 18, 2026 16:12
@gwdp
gwdp requested a review from hirbod September 18, 2026 16:17
@gwdp
gwdp force-pushed the gwdp/serve-sim-cors-origin branch from 014a9a4 to b83f4df Compare September 21, 2026 18:42
@gwdp
gwdp marked this pull request as ready for review September 21, 2026 18:42
@github-actions

Copy link
Copy Markdown

✅ Thank you for adding the changelog entry!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants