[build-tools] Upload embedded bundle by default on SDK 58+ and rename env var - #4433
Open
brentvatne wants to merge 3 commits into
Open
brentvatne wants to merge 3 commits into
brentvatne wants to merge 3 commits into
Conversation
… env var Rename EAS_UPDATE_EXPERIMENTAL_UPLOAD_EMBEDDED_BUNDLE to EAS_UPDATE_UPLOAD_EMBEDDED_BUNDLE and enable the upload by default for projects on SDK 58 and later. Set it to 0 to disable, or 1 to opt in on earlier SDKs. The old name is still honored with a deprecation warning.
3 tasks
Member
Author
|
Docs: expo/expo#50307 |
EAS_UPDATE_EXPERIMENTAL_UPLOAD_EMBEDDED_BUNDLE stays the supported way to opt in on SDK 57 and below, where the feature is still experimental. Drop the deprecation warning.
|
✅ Thank you for adding the changelog entry! |
brentvatne
marked this pull request as ready for review
September 17, 2026 17:12
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4433 +/- ##
==========================================
+ Coverage 72.29% 72.30% +0.01%
==========================================
Files 970 970
Lines 46133 46145 +12
Branches 9903 9909 +6
==========================================
+ Hits 33349 33361 +12
Misses 11789 11789
Partials 995 995 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
gwdp
approved these changes
Sep 17, 2026
gwdp
left a comment
Contributor
There was a problem hiding this comment.
LGTM, Thank you for doing it!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Uploading the embedded bundle after an EAS Build lets EAS Update serve bsdiff patches to fresh installs on their very first update check. It has been opt-in behind
EAS_UPDATE_EXPERIMENTAL_UPLOAD_EMBEDDED_BUNDLE. This makes it the default for projects on SDK 58 and later, controlled by a non-experimental env var, while keeping it experimental and opt-in on SDK 57 and below.How
shouldUploadEmbeddedBundlefalls back tometadata.sdkVersionand enables the upload only for SDK>=58. An unknown SDK version leaves it off.EAS_UPDATE_UPLOAD_EMBEDDED_BUNDLEto0(orfalse) to disable the upload.EAS_UPDATE_EXPERIMENTAL_UPLOAD_EMBEDDED_BUNDLE=1remains the supported opt-in, with no deprecation warning.Docs: expo/expo#50307
Test Plan
Unit tests in
packages/build-tools/src/builders/__tests__/android.test.tscover: default on for SDK 58, default off for SDK 57 and for unknown SDK, explicit1on SDK 57, explicit0on SDK 58, and the experimental var on SDK 57.yarn lintandtscpass.Checklist
changelog.mdentry🤖 Generated with Claude Code