Stabilize visual smoke Player View state

electron/preload.ts

@@ -20,6 +20,7 @@ import type {
 } from "../src/shared/localvtt.js";
 
 const api: LocalVttApi = {
+  isVisualSmokeTest: process.env.LOCALVTT_VISUAL_SMOKE_TEST === "1",
   createCampaign: () => ipcRenderer.invoke("campaign:create") as Promise<CampaignSummary | null>,
   openCampaign: () => ipcRenderer.invoke("campaign:open") as Promise<CampaignSummary | null>,
   openRecentCampaign: (campaignPath: string) => ipcRenderer.invoke("campaign:openRecent", campaignPath) as Promise<CampaignSummary>,

src/renderer/devLocalVtt.ts

@@ -75,6 +75,7 @@ export function installDevLocalVtt() {
   };
 
   const api: LocalVttApi = {
+    isVisualSmokeTest: false,
     createCampaign: async () => {
       campaign = createDevCampaign();
       scenes.clear();

src/renderer/lib/player-view/playerIdleState.ts

@@ -15,10 +15,14 @@ export const PLAYER_BLACKOUT_STATE: PlayerIdleState = {
 };
 
 type PlayerIdleApi = {
+  isVisualSmokeTest?: boolean;
   showPlayerIdle: (title: string, message: string, variant?: PlayerIdleState["variant"]) => Promise<unknown>;
 };
 
 export async function showDefaultPlayerHold(api: PlayerIdleApi = window.localVtt): Promise<void> {
+  if (api.isVisualSmokeTest) {
+    return;
+  }
   await api.showPlayerIdle(DEFAULT_PLAYER_HOLD_STATE.title, DEFAULT_PLAYER_HOLD_STATE.message, DEFAULT_PLAYER_HOLD_STATE.variant);
 }
 

src/shared/localVttApi.ts

@@ -47,6 +47,7 @@ export interface PlayerDisplaySummary {
 }
 
 export interface LocalVttApi {
+  isVisualSmokeTest: boolean;
   createCampaign: () => Promise<CampaignSummary | null>;
   openCampaign: () => Promise<CampaignSummary | null>;
   openRecentCampaign: (campaignPath: string) => Promise<CampaignSummary>;

tests/renderer/playerIdleState.test.ts

@@ -16,6 +16,14 @@ describe("player idle state helpers", () => {
     );
   });
 
+  it("does not override visual smoke fixture state with the default hold state", async () => {
+    const api = { isVisualSmokeTest: true, showPlayerIdle: vi.fn().mockResolvedValue(undefined) };
+
+    await showDefaultPlayerHold(api);
+
+    expect(api.showPlayerIdle).not.toHaveBeenCalled();
+  });
+
   it("shows the blackout state", async () => {
     const api = { showPlayerIdle: vi.fn().mockResolvedValue(undefined) };