Conversation
There was no workflow, so 851 tests and four gates ran only where someone remembered to run them. The gates are the part worth having automated. Product-neutrality is the rule the whole architecture rests on, it is enforced by a script rather than by review precisely because a well-meaning change reintroduces it easily, and a green test suite says nothing at all about whether it still holds. Node is pinned to the version in the Volta block rather than left as "22", because a build that passes on a Node nobody develops against is a build that proves less than it appears to.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is no workflow in this repository, so 851 tests and four neutrality gates run only where someone remembers to run them.
Why the gates matter most here
Product-neutrality is the rule the whole architecture rests on, and it is enforced by a script rather than by review precisely because a well-meaning change reintroduces it easily — a hardcoded kind name, a product-shaped CSS rule, a branded file name. A green test suite says nothing at all about whether it still holds, which is exactly why
check:neutralityexists and exactly why it should not depend on anyone remembering.Node is pinned
To
22.23.1, the version in thevoltablock, rather than left as22. A build that passes on a Node nobody develops against proves less than it appears to.What it runs
npm ci, then build, test,check:neutrality, andnpm run package— uploading the.vsixso a branch can be installed and tried without a local build. Concurrency is set so a second push to a branch cancels the first.