Repository navigation
Conversation
elysia 2.0.0-beta.11 renamed `ElysiaStatus#code` to `#status`. The adapter still read `code`, got `undefined`, and srvx answered 200 for every `status(n, ...)`, returned or thrown, including from `beforeHandle`. Raise the elysia peer floor to beta.11 and develop against it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
From elysia 2.0.0-beta.18, `ElysiaAdapterOptions` has no `name` or `websocket`, so the adapter fails to typecheck. Nothing in elysia reads either any more; WebSocket support comes from the `setup` hook and the config `listen` hands to srvx. The websocket test checks `setup` instead. Develop against 2.0.0-beta.21. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
follow up to #65