Skip to content

More Colors Update - #101

Merged
elkogerville merged 25 commits into
mainfrom
colors
Aug 8, 2026
Merged

elkogerville merged 25 commits into
mainfrom
colors

Conversation

@elkogerville

Copy link
Copy Markdown
Owner

Adds more colorsets to va :)

  • supernatural, ditto, supernova, supersequential, and celestial.

  • Created aliases for colorsets (va -> visualastro, vb -> ditto)

  • created set_title method, which uses config.fontsizes.title as the fontsize

  • transform and factor are now config parameters: config.color_transform and config.color_transform_factor.
    This way you can transform the colors using config, which will apply this globally to all colors in va

small fixes:

  • added lw to plot_colorset
  • rename get_complimentary_colors to _transform_colors
  • get_colors now queries mpl.color_sequences instead of COLORSETS now that va colorsets are registered with mpl
  • fix README

@qiushitian

qiushitian commented Aug 6, 2026

Copy link
Copy Markdown
Collaborator

1. Why is there no automatic CI testing for this PR?
2. Unrelated to this PR but the DOI in README.md is the old one. I think we should just link it to the "all versions" DOI (10.5281/zenodo.21729933) so we don't need to keep updating it. Thoughts? See this Zenodo help page.

@shadowbehindthebread

Copy link
Copy Markdown
Collaborator

dear pm @qiushitian what is ci testing lol

@qiushitian

Copy link
Copy Markdown
Collaborator

dear pm @qiushitian what is ci testing lol

@shadowbehindthebread Its just the "checks"/blue check mark as in the "All checks have passed" right below. i'm actually not sure if its called ci testing lol

@shadowbehindthebread

Copy link
Copy Markdown
Collaborator

dear pm @qiushitian what is ci testing lol

@shadowbehindthebread Its just the "checks"/blue check mark as in the "All checks have passed" right below. i'm actually not sure if its called ci testing lol

ohhh hahaah i thought maybe u wanted a new type of test ... also i was wondering why the tests werent automatically going for each commit too lolll

@shadowbehindthebread shadowbehindthebread left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WOOOO GOOD JOB INGENIEUR BIG FAN OF UR COLORS :)

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WOOO BIG FAN

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mmmmmmmmmm

@qiushitian

Copy link
Copy Markdown
Collaborator

added a "citing visualastro" section to readme. looks okay @elkogerville ? @shadowbehindthebread darken_colors is now in the notebook

@elkogerville
elkogerville merged commit 260ea9b into main Aug 8, 2026
15 checks passed
@elkogerville
elkogerville deleted the colors branch August 8, 2026 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants