Docs: note the -800 HU floor in the density conversion - #416
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Thank you for your PR! Please ensure you've read DiffDRR's development guide.
Owner
|
@danielemolino thank you for the PR! can you please fix the failing test (should just need to run |
Owner
|
thanks, now you can see why i moved away from nbdev for future projects :) closes #416 |
Contributor
Author
|
Haha, I can definitely see why, thanks for the review and for merging! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follows #415. Documentation only, no behaviour change, consistent with #378 being closed as wontfix for DiffDRR.
Two additions:
transform_hu_to_densitydescribing what the thresholds do, includingthat everything at or below −800 HU is collapsed onto a single value;
readdocs noting that this removes most aerated lung parenchyma onthoracic CT, and pointing users who need it preserved to
nanodrr.hu_to_mu.The intent is only to make the convention visible to someone loading a chest CT, since
transform_hu_to_densityisexportiand the behaviour isn't discoverable from the docstoday.
Happy to reword or trim anything, including dropping the nanodrr pointer if you'd rather not cross-reference packages here.