Skip to content

Docs: note the -800 HU floor in the density conversion - #416

Merged
eigenvivek merged 3 commits into
eigenvivek:mainfrom
danielemolino:main
Sep 8, 2026
Merged

eigenvivek merged 3 commits into
eigenvivek:mainfrom
danielemolino:main

Conversation

@danielemolino

Copy link
Copy Markdown
Contributor

Follows #415. Documentation only, no behaviour change, consistent with #378 being closed as wontfix for DiffDRR.

Two additions:

  • a docstring on transform_hu_to_density describing what the thresholds do, including
    that everything at or below −800 HU is collapsed onto a single value;
  • a callout in the read docs noting that this removes most aerated lung parenchyma on
    thoracic CT, and pointing users who need it preserved to nanodrr.hu_to_mu.

The intent is only to make the convention visible to someone loading a chest CT, since
transform_hu_to_density is exporti and the behaviour isn't discoverable from the docs
today.
Happy to reword or trim anything, including dropping the nanodrr pointer if you'd rather not cross-reference packages here.

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your PR! Please ensure you've read DiffDRR's development guide.

@eigenvivek

Copy link
Copy Markdown
Owner

@danielemolino thank you for the PR! can you please fix the failing test (should just need to run nbdev_clean; nbdev_export), then happy to merge

@eigenvivek

Copy link
Copy Markdown
Owner

thanks, now you can see why i moved away from nbdev for future projects :)

closes #416

@eigenvivek
eigenvivek merged commit ac68fb6 into eigenvivek:main Sep 8, 2026
2 checks passed
@danielemolino

Copy link
Copy Markdown
Contributor Author

Haha, I can definitely see why, thanks for the review and for merging!
At least this gave me the chance to learn a few new commands along the way

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants