Repository navigation
fix: install add-ons without agreeToLicense on R2026b and later - #73
Merged
Merged
Conversation
From R2026b, matlab.addons.install accepts the license agreement by default and errors when the agreeToLicense argument is false (matlab_addons:install:licenseAgreementDialogDeprecationNotice). An argument of true is still accepted. installFexPackage passed the AgreeToLicense option, which defaults to false, so installing a FileExchange requirement packaged as .mltbx failed on R2026b. It now calls matlab.addons.install without the argument from R2026b. Earlier releases still receive AgreeToLicense. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
Test Results36 tests 36 ✅ 26s ⏱️ Results for commit 35e4663. ♻️ This comment has been updated with latest results. |
From R2026b MATLAB accepts an add-on's license agreement on install, so AgreeToLicense false can no longer decline it. installFexPackage now warns (MatBox:Setup:AgreeToLicenseIgnored) after installing an .mltbx package on R2026b or later when the caller passed false. The option has no default in installRequirements, installFromSourceUri and installFexPackage, and is forwarded only when given, so omitting it does not warn. On earlier releases an omitted option still means false. SetupTest checks on R2026b and later that an explicit false warns and that an omitted option does not. Both uninstall the test add-on first, because installFexPackage skips an add-on that is already installed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From R2026b,
matlab.addons.installaccepts the license agreement by default and errors when theagreeToLicenseargument isfalse(matlab_addons:install:licenseAgreementDialogDeprecationNotice). An argument oftrueis still accepted.installFexPackagepassed theAgreeToLicenseoption, which defaults tofalse, soinstallRequirementsfailed on R2026b for any FileExchange requirement packaged as.mltbx. This is what fails the threeSetupTesttests.installFexPackagenow callsmatlab.addons.installwithout the argument from R2026b. Earlier releases still receiveAgreeToLicense. From R2026b the option has no effect, because MATLAB no longer offers a way to decline the license. When a caller passesAgreeToLicenseasfalseexplicitly,installFexPackagewarns (MatBox:Setup:AgreeToLicenseIgnored) after installing an.mltbxpackage on R2026b or later.To tell an explicit
falsefrom an omitted option,AgreeToLicensehas no default ininstallRequirements(asAgreeToLicenses),installFromSourceUriandinstallFexPackage, and each forwards it only when given. Omitting it does not warn, and on earlier releases it still meansfalse.SetupTestchecks both cases on R2026b and later; each test uninstalls the test add-on first, becauseinstallFexPackageskips an add-on that is already installed.The R2026a and R2026b behaviour of each call was observed in a probe run in github-actions-sandbox. MathWorks documents the change under "R2026b: agreeToLicense argument no longer supported" on the
matlab.addons.installpage.The
packageToolboxtests also fail on R2026b, for a separate reason fixed in #74.🤖 Generated with Claude Code