[2467] Add connected elements tool to the General View by AxelRICHARD · Pull Request #2496 · eclipse-syson/syson

AxelRICHARD · 2026-08-31T15:25:05Z

Expose existing elements connected to the selected element through both inbound and outbound General View relationships.

Add the tool icon and integration coverage.

Bug: #2467

PLEASE READ ALL ITEMS AND CHECK ONLY RELEVANT CHECKBOXES BELOW

Auto review

Have you reviewed this PR? Please do a first quick review, It is very useful to detect typos and missing copyrights, check comments, check your code... The reviewer will thank you for that :)

Project management

Has the pull request been added to the relevant milestone?
Have the priority: and pr: labels been added to the pull request? (In case of doubt, start with the labels priority: low and pr: to review later)
Have the relevant issues been added to the pull request?
Have the relevant labels been added to the issues? (area:, type:)
Have the relevant issues been added to the same project milestone as the pull request?

Changelog and release notes

Has the CHANGELOG.adoc + doc/content/modules/user-manual/pages/release-notes/YYYY.MM.0.adoc been updated to reference the relevant issues?
Have the relevant API breaks been described in the CHANGELOG.adoc?
Are the new / upgraded dependencies mentioned in the relevant section of the CHANGELOG.adoc?
In case of a change with a visual impact, are there any screenshots in the doc/content/modules/user-manual/pages/release-notes/YYYY.MM.0.adoc?
In case of a key change, has the change been added to Key highlights section in doc/content/modules/user-manual/pages/release-notes/YYYY.MM.0.adoc?

Documentation

Have you included an update of the documentation in your pull request? Please ask yourself if an update (installation manual, user manual, developer manual...) is needed and add one accordingly.

Tests

Is the code properly tested? Any pull request (fix, enhancement or new feature) should come with a test (or several). It could be unit tests, integration tests or cypress tests depending on the context. Only doc and releng pull request do not need for tests.

Expose existing elements connected to the selected element through both inbound and outbound General View relationships. Add the tool icon and integration coverage. Bug: #2467 Signed-off-by: Cedric Brun <cedric.brun@obeo.fr>

AxelRICHARD · 2026-09-01T15:32:47Z

+/**
+ * Tests for {@link DiagramMutationExposeService}.
+ *
+ * @author arichard


@author cbrun

Fixed: changed the author to cbrun.

AxelRICHARD · 2026-09-01T15:34:06Z

        return element;
    }

+    /** Adds every project element connected to the given element to the current view. */


Please add full javadoc

Added full Javadoc, including the parameters and return value, and updated it to reflect the selection-based filtering.

AxelRICHARD · 2026-09-01T15:34:19Z

+        return element;
+    }
+
+    private Set<Element> getConnectedElements(Element element, ResourceSet resourceSet) {


please add full javadoc here and on every new method you introduced

Added Javadoc to the helper methods introduced here, documenting connected-element discovery, project-resource filtering, parameters and return values.

AxelRICHARD · 2026-09-01T15:36:02Z

+        return resource != null && resourceSet.getResources().contains(resource) && !ElementUtil.isStandardLibraryResource(resource);
+    }
+
+    private EdgeEndpoints getGeneralViewEdgeEndpoints(Element candidate) {


I think an EMF Switch in a dedicated class would be more suitable

Agreed. I extracted the endpoint resolution into GeneralViewEdgeEndpointsSwitch, extending SysmlSwitch, with dedicated tests.

AxelRICHARD · 2026-09-01T15:39:03Z

please update the javadoc

Updated the Javadoc to include the connected-elements tool, for both the single-selection and multi-selection sections.

AxelRICHARD · 2026-09-01T15:40:53Z

-                .build();
+        var builder = this.diagramBuilderHelper.newNodeToolSection().name("Related Elements");
+        if (nested) {
+            builder.nodeTools(this.addExistingElementsTool(false, true), this.addExistingElementsTool(true, true), this.addExistingConnectedElementsTool());


why do you add your tool only if nested is true?

You're right, that restriction was unnecessary. The tool is now included for both values of nested, making it available from compartments as well.

AxelRICHARD · 2026-09-01T15:41:05Z

No need to add it here?

Added it to the multi-selection section too. The operation collects connected candidates for the whole selection and filters them before exposing anything, so the result does not depend on selection order.

Extract edge endpoint resolution into an EMF switch and document the new methods. Enable the tool for compartments and multiple selections. Bug: #2467 Signed-off-by: Cedric Brun <cedric.brun@obeo.fr>

cbrun · 2026-09-08T15:30:03Z

Following our discussion, the tool now excludes connected elements that can be represented as ports or inside a compartment/container of any selected node, even when the compartment is hidden. This uses the node descriptions rather than a blacklist of semantic types. Independent connected elements are still exposed, and existing representations are preserved.

Added unit and integration coverage, including single and multiple selections. The local build passes, and all coverage thresholds are met.

Filter candidates against all selected nodes before exposure, including hidden compartments and border node representations. Bug: #2467 Signed-off-by: Cedric Brun <cedric.brun@obeo.fr>

AxelRICHARD added this to the 2026.11.0 milestone Aug 31, 2026

AxelRICHARD added pr: to review later priority: low labels Aug 31, 2026

AxelRICHARD linked an issue Aug 31, 2026 that may be closed by this pull request

Add existing connected elements to a General View #2467

Open

cbrun force-pushed the cbr/enh/addreferenced branch from 125ecbf to 51dcaf9 Compare September 1, 2026 11:10

[2467] Add connected elements tool to the General View

f4d7a9c

Expose existing elements connected to the selected element through both inbound and outbound General View relationships. Add the tool icon and integration coverage. Bug: #2467 Signed-off-by: Cedric Brun <cedric.brun@obeo.fr>

cbrun force-pushed the cbr/enh/addreferenced branch from 51dcaf9 to f4d7a9c Compare September 1, 2026 13:18

AxelRICHARD commented Sep 1, 2026

View reviewed changes

cbrun self-assigned this Sep 7, 2026

[2467] Address connected elements review feedback

5ecd82f

Extract edge endpoint resolution into an EMF switch and document the new methods. Enable the tool for compartments and multiple selections. Bug: #2467 Signed-off-by: Cedric Brun <cedric.brun@obeo.fr>

cbrun force-pushed the cbr/enh/addreferenced branch from 172ea3d to b9b655a Compare September 8, 2026 15:19

[2467] Exclude nested content from connected element exposure

82e117e

Filter candidates against all selected nodes before exposure, including hidden compartments and border node representations. Bug: #2467 Signed-off-by: Cedric Brun <cedric.brun@obeo.fr>

cbrun force-pushed the cbr/enh/addreferenced branch from b9b655a to 82e117e Compare September 8, 2026 15:35

Uh oh!

Conversation

AxelRICHARD commented Aug 31, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PLEASE READ ALL ITEMS AND CHECK ONLY RELEVANT CHECKBOXES BELOW

Auto review

Project management

Changelog and release notes

Documentation

Tests

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cbrun commented Sep 8, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

AxelRICHARD commented Aug 31, 2026 •

edited

Loading