Skip to content

Find/Replace overlay: renamed tooltips - #4357

Open
r-mennig wants to merge 1 commit into
eclipse-platform:masterfrom
r-mennig:find_replace_rename_tooltips
Open

Find/Replace overlay: renamed tooltips#4357
r-mennig wants to merge 1 commit into
eclipse-platform:masterfrom
r-mennig:find_replace_rename_tooltips

Conversation

@r-mennig

@r-mennig r-mennig commented Sep 7, 2026

Copy link
Copy Markdown
Contributor

Currently, the tooltips for the buttons in the Find/Replace Overlay to find the next / previous / all hits are shown as "Search forward" / "Search backward" / "Search all". The search view however uses the tooltips "Show Next Match" / "Show Previous Match".

To closer align both sets of tooltips, this PR changes the "Search forward", "Search backwards" and "Search all" tooltips to "Find Next", "Find Previous" and "Find All" ("Find" is used here to signal to the user that a search is being executed, unlike in the search view in which all matches are already known).

Additionally, this PR also updates the capitalization of all find/replace overlay tooltips according to the Eclipse UI style guide (see Guideline 1.5). The placeholder texts in the search / replace bar are not changed, as those are already capitalized correctly according to Guideline 1.6.

@r-mennig

r-mennig commented Sep 7, 2026

Copy link
Copy Markdown
Contributor Author

Ping @HeikoKlare

@github-actions

github-actions Bot commented Sep 7, 2026

Copy link
Copy Markdown
Contributor

Test Results

   858 files  ± 0     858 suites  ±0   53m 56s ⏱️ + 15m 45s
 8 302 tests ± 0   8 059 ✅ ± 0  243 💤 ± 0  0 ❌ ±0 
20 775 runs  +86  20 105 ✅ +63  670 💤 +23  0 ❌ ±0 

Results for commit 6f7d5ba. ± Comparison against base commit 94cf8a1.

♻️ This comment has been updated with latest results.

@HeikoKlare HeikoKlare left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the proposal. I like the consistent naming of using "find next/previous" instead of "search forward/backward" and would be in favor of merging this renaming.

Comment thread bundles/org.eclipse.ui.workbench.texteditor/plugin.properties
Renames "Search forward", "Search backwards" and "Search all" tooltips
to "Find next", "Find previous" and "Find all" to closer match existing
naming in search view.

Also updates all find/replace overlay tooltips according to Eclipse UI
style guide.
@r-mennig
r-mennig force-pushed the find_replace_rename_tooltips branch from 1c61b06 to 6f7d5ba Compare September 8, 2026 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants