Repository navigation
chore(cli): loop over options ignored for prepackaged publish - #2335
Merged
Merged
Conversation
trivikr
force-pushed
the
cli-ignoring-option-loop
branch
from
October 15, 2026 18:42
1d73280 to
457f051
Compare
Contributor
|
The refactor looks correct and behaviour-neutral: same conditions, same order, and none of the seven options has a default, so each is A few points, the first one for this PR:
The rest is pre-existing and better suited to a follow-up:
|
Contributor
Author
Added in f7482cb |
Replace seven near-identical checks in the publish action with a single loop over [flag, value] pairs. Warnings and their order are unchanged. Signed-off-by: Trivikram Kamat <16024985+trivikr@users.noreply.github.com>
Signed-off-by: Trivikram Kamat <16024985+trivikr@users.noreply.github.com>
trivikr
force-pushed
the
cli-ignoring-option-loop
branch
from
October 19, 2026 02:24
f7482cb to
eca47b0
Compare
netomi
approved these changes
Oct 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace seven near-identical checks in the publish action with a single loop over [flag, value] pairs.
Warnings and their order are unchanged.