Repository navigation
fix: deliver credentials with their own credentialType - #1144
Merged
paullatzelsperger merged 1 commit intoOct 12, 2026
Merged
paullatzelsperger merged 1 commit into
paullatzelsperger merged 1 commit into
Conversation
The CredentialMessage that delivers credentials to a Holder had the credentialType "VerifiableCredential" for every credential, because the type list was filtered for it instead of excluding it, and a credential without that type could not be delivered at all. The credentialType is now the type of the credential besides VerifiableCredential, i.e. the type of its credential definition. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
wolf4ood
approved these changes
Oct 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR changes/adds
credentialTypeof each credential in theCredentialMessagethat the IssuerService delivers to a Holder is thetype of the credential besides
VerifiableCredential, i.e. the type of its credential definition, e.g.MembershipCredential. A credential without another type falls back toVerifiableCredential.Why it does that
DcpCredentialStorageClientfiltered the types of the credential forVerifiableCredentialinstead of excluding it, soevery delivered credential had the
credentialType"VerifiableCredential", and a Holder that relies on it got thewrong type. A credential without the type
VerifiableCredentialmade the delivery throw. The IdentityHub as Holder wasnot affected, as it reads the types from the credential itself.
Linked Issue(s)
Closes #1143
🤖 Generated with Claude Code