chore(native): make knip pass — drop duplicate deps, cwd-independent jest mapping - #58
Open
ivanbanov wants to merge 1 commit into
Open
chore(native): make knip pass — drop duplicate deps, cwd-independent jest mapping#58ivanbanov wants to merge 1 commit into
ivanbanov wants to merge 1 commit into
Conversation
…jest mapping `pnpm knip` failed on the native shell alone, for four unrelated reasons: - expo, react and react-native were listed in both dependencies and devDependencies; the devDependencies copies go (the lockfile already resolved the dependencies specifiers). - jest-expo turns the nearest tsconfig's `paths` into moduleNameMapper entries relative to `<rootDir>`, which for this package points nowhere and which tsconfig is nearest depends on the cwd. Filter the @dunky.dev mappers out: the workspace links plus the resolver do that job. - knip's expo plugin infers expo-updates unless the manifest says updates are off (they are: `updates.enabled: false`), and expo-system-ui from `userInterfaceStyle`, which a stories harness has no use for on Android — ignored with the reason, alongside jest-expo's own @expo/vector-icons mapping and the babel-preset-expo / babel-jest modules the presets resolve themselves. - the on-device Storybook reaches the stories through the generated, gitignored storybook.requires.ts, so the story files are entries for knip, mirroring the react and solid workspaces. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pnpm knipfailed on the native shell alone, for four unrelated reasons:devDependencies; the devDependencies copies go (the lockfile already
resolved the dependencies specifiers).
pathsinto moduleNameMapperentries relative to
<rootDir>, which for this package points nowhereand which tsconfig is nearest depends on the cwd. Filter the @dunky.dev
mappers out: the workspace links plus the resolver do that job.
updates are off (they are:
updates.enabled: false), and expo-system-uifrom
userInterfaceStyle, which a stories harness has no use for onAndroid — ignored with the reason, alongside jest-expo's own
@expo/vector-icons mapping and the babel-preset-expo / babel-jest
modules the presets resolve themselves.
gitignored storybook.requires.ts, so the story files are entries for
knip, mirroring the react and solid workspaces.
Co-Authored-By: Claude Fable 5.1 noreply@anthropic.com