Conversation
bfng72
commented
Sep 14, 2026
bfng72
commented
- enabled consent editing after submission, db will update accordingly
- added a line on dashboard if application is submitted/accepted/waiting-list to hint user that they can edit their consents on the submit page
…ter application submission
Lordfirespeed
requested changes
Sep 14, 2026
Lordfirespeed
left a comment
Lordfirespeed
left a comment
Member
There was a problem hiding this comment.
Really nice work, great job! just a couple of changes and you should be good to go :)
| } | ||
|
|
||
| private async saveConsents(userId: string, payload: z.infer<typeof submitFormSchema>){ | ||
| return prisma.$transaction([ |
| }), | ||
| ]) | ||
|
|
||
| await this.saveConsents(request.userProfile.sub, payload) |
Member
There was a problem hiding this comment.
This being moved to here means the consents are now being saved in a separate transaction from the user submission state being updated - we can't have that!
add a function which returns the values from all the upsertConsent calls in an array (don't await them), then you can spread that array into the transaction above. Lemme know if you'd like an example in case that doesn't make sense
| Check your inbox for a confirmation email - you will need the QR code inside to check-in on the day of the | ||
| event. | ||
| </p> | ||
| <p>You can still change your consents <Link href="/dashboard/submit" className="underline">here</Link>. Or just click "Submit" on the navigation bar.</p> |
Member
There was a problem hiding this comment.
Nitpick: since this text is repeated, I'd prefer you make a small component for it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.