fix(cli): warn when v2 detail lines are capped - #25
Merged
Conversation
V2 detail responses cap inline items at 100 and set has_more_lines plus lines_count. Human output never read either flag, so a 250-line journal entry looked complete. Remaining lines cannot be fetched on v2, so warn instead.
Warkanlock
commented
Sep 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
itemsat 100 and sethas_more_lines+lines_count. Human detail never read either flag, so a 250-line journal entry looked complete./{resource}/{n}/lines/moved to v2.0.0-alpha or was dropped). Warn instead of implying completeness.Fixes EOPS-371
Changes
_warn_truncated_linesafter every human detail render (JE, invoice, IJE, generic)Warning: showing 100 of 250 lines. The API caps inline lines at 100.lines_countis missing:Warning: showing N lines. The API omitted the rest.tests/test_output.pyTest plan
uv run pytest)uv run ruff check .)journal-entries get 2(2 lines) prints no warninginvoices get 1prints no warninghas_more_lines=True