refactor(sandboxer): promote docker to top-level provider - #150
Open
dungdm93 wants to merge 3 commits into
Open
Conversation
docker to top-level provider
dungdm93
force-pushed
the
sanboxer-docker
branch
from
September 10, 2026 10:43
3c79a4a to
195058a
Compare
dungdm93
force-pushed
the
sanboxer-docker
branch
from
September 10, 2026 10:46
195058a to
8a512e2
Compare
dungdm93
force-pushed
the
sanboxer-docker
branch
from
September 10, 2026 10:48
8a512e2 to
c2c4422
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR refactors the container sandboxer architecture:
ProviderDocker = "docker"to a first-class sandboxer provider, replacing the legacycontainerprovider andimplementation = "docker"field.core/pkg/sandboxer/containerinto a vendor-agnostic container orchestration library (handling job/service containers, bridge networking, sandbox layouts, and runtime provision bind mounts) without anymoby/mobydependencies.core/pkg/sandboxer/dockeras the concrete Docker sandboxer provider, configuring the Docker client, telemetry, and delegating tocontainer.New.hostandincussandboxers viacontainer.NewBootstrapper.Changes
core/config/config.go: ReplaceProviderContainerwithProviderDocker, updateDefaultConfig.core/pkg/sandboxer/container: Remove Docker SDK dependencies andinit()provider registration; exportDefaultImage,New,NewBootstrapper,NewProvisioner,NewSandbox.core/pkg/sandboxer/docker: Add new package registeringconfig.ProviderDocker, definingConfig,DefaultConfig,factory, andNew.config,sandboxer/container, andsandboxer/docker.docs/superpowers/.Verification
core/pkg/sandboxer/...,core/config/...,core/...,runner-gha, andrunner-giteausing-tags=containers_image_openpgp,exclude_graphdriver_btrfs.