Repository navigation
[1st PR of Certificate Selector] Support parsing Kubernetes secrets containing intermediate certificates - #3058
Open
Xulei-NL wants to merge 9 commits into
Conversation
Xulei-NL
marked this pull request as ready for review
October 6, 2026 19:07
Contributor
Author
|
Have no idea why the test pipeline for macOS failed almost every time. 😟 Couldn't see the test details. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
I tried to create a PR for my new Certificate Selector logic. However the code without test cases exceeds 600 lines, which was too large for code review.
Plan
This is the plan to split up the whole Certificate Selector logic into 6 small PRS.
TlsSecretCertificateParserand its interfaceTlsSecretCertificateParserTeststo assert the returned leaf and intermediates individually. Cover PEM and DER input, missing data, and certificate chains. Avoid checking the tuple itself for null: assert its elements.TlsSecretCertificateStoreand its interfaceTlsIngressBindingIndexand its interfaceIngressCachechanges and required DI wiringHttpsListenPortsand multi-port Kestrel configurationThis PR
This PR is the first one to support parsing k8s certificate secrets without breaking any existing code.
Feedback appreciated
I'm appreciated to all feedbacks.