LEGO: Pull request from lego/hb_5df43909-4a19-4f55-bc3f-9ea8fccf3c82_20260917175401680 to main - #26657
Open
csigs wants to merge 1 commit into
Open
LEGO: Pull request from lego/hb_5df43909-4a19-4f55-bc3f-9ea8fccf3c82_20260917175401680 to main#26657csigs wants to merge 1 commit into
csigs wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
A moderate Italian framework translation issue and unresolved generated-file and spelling issues remain.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
Adds localized LCX template strings and metadata for Apple platform templates across multiple locales.
Changes:
- Localizes tvOS, macOS, Mac Catalyst, and iOS templates.
- Updates template names, descriptions, and framework choices.
- Includes unresolved translation corrections and generated-file workflow issues.
File summaries
| File | Review note |
|---|---|
macios/Localize/loc/zh-Hans/macios/dotnet/Templates/Microsoft.tvOS.Templates/tvostest/csharp/.template.config/localize/templatestrings.en.json.lcl |
Nit (1 vote): generated .lcl artifact should be regenerated from English sources. |
macios/Localize/loc/zh-Hans/macios/dotnet/Templates/Microsoft.tvOS.Templates/tvoslib/visualbasic/.template.config/localize/templatestrings.en.json.lcl |
No specific finding. |
macios/Localize/loc/zh-Hans/macios/dotnet/Templates/Microsoft.tvOS.Templates/tvosbinding/csharp/.template.config/localize/templatestrings.en.json.lcl |
Nit (3 votes): correct tviOS to tvOS; nit (2 votes): avoid directly editing generated artifacts. |
macios/Localize/loc/zh-Hans/macios/dotnet/Templates/Microsoft.macOS.Templates/macostest/csharp/.template.config/localize/templatestrings.en.json.lcl |
No specific finding. |
macios/Localize/loc/zh-Hans/macios/dotnet/Templates/Microsoft.macOS.Templates/macoslib/visualbasic/.template.config/localize/templatestrings.en.json.lcl |
No specific finding. |
macios/Localize/loc/zh-Hans/macios/dotnet/Templates/Microsoft.macOS.Templates/macoslib/csharp/.template.config/localize/templatestrings.en.json.lcl |
No specific finding. |
macios/Localize/loc/zh-Hans/macios/dotnet/Templates/Microsoft.macOS.Templates/macosbinding/csharp/.template.config/localize/templatestrings.en.json.lcl |
No specific finding. |
macios/Localize/loc/zh-Hans/macios/dotnet/Templates/Microsoft.MacCatalyst.Templates/maccatalysttest/csharp/.template.config/localize/templatestrings.en.json.lcl |
No specific finding. |
macios/Localize/loc/zh-Hans/macios/dotnet/Templates/Microsoft.iOS.Templates/iostest/csharp/.template.config/localize/templatestrings.en.json.lcl |
No specific finding. |
macios/Localize/loc/zh-Hans/macios/dotnet/Templates/Microsoft.iOS.Templates/ioslib/visualbasic/.template.config/localize/templatestrings.en.json.lcl |
No specific finding. |
macios/Localize/loc/zh-Hans/macios/dotnet/Templates/Microsoft.iOS.Templates/ioslib/csharp/.template.config/localize/templatestrings.en.json.lcl |
No specific finding. |
macios/Localize/loc/zh-Hans/macios/dotnet/Templates/Microsoft.iOS.Templates/iosbinding/csharp/.template.config/localize/templatestrings.en.json.lcl |
No specific finding. |
macios/Localize/loc/tr/macios/dotnet/Templates/Microsoft.tvOS.Templates/tvostest/csharp/.template.config/localize/templatestrings.en.json.lcl |
No specific finding. |
macios/Localize/loc/tr/macios/dotnet/Templates/Microsoft.tvOS.Templates/tvoslib/visualbasic/.template.config/localize/templatestrings.en.json.lcl |
No specific finding. |
macios/Localize/loc/tr/macios/dotnet/Templates/Microsoft.tvOS.Templates/tvosbinding/csharp/.template.config/localize/templatestrings.en.json.lcl |
No specific finding. |
macios/Localize/loc/tr/macios/dotnet/Templates/Microsoft.macOS.Templates/macostest/csharp/.template.config/localize/templatestrings.en.json.lcl |
No specific finding. |
macios/Localize/loc/tr/macios/dotnet/Templates/Microsoft.macOS.Templates/macoslib/visualbasic/.template.config/localize/templatestrings.en.json.lcl |
No specific finding. |
macios/Localize/loc/tr/macios/dotnet/Templates/Microsoft.macOS.Templates/macosbinding/csharp/.template.config/localize/templatestrings.en.json.lcl |
No specific finding. |
macios/Localize/loc/tr/macios/dotnet/Templates/Microsoft.iOS.Templates/ioslib/visualbasic/.template.config/localize/templatestrings.en.json.lcl |
No specific finding. |
macios/Localize/loc/tr/macios/dotnet/Templates/Microsoft.iOS.Templates/iosbinding/csharp/.template.config/localize/templatestrings.en.json.lcl |
No specific finding. |
macios/Localize/loc/ru/macios/dotnet/Templates/Microsoft.tvOS.Templates/tvostest/csharp/.template.config/localize/templatestrings.en.json.lcl |
No specific finding. |
macios/Localize/loc/ru/macios/dotnet/Templates/Microsoft.macOS.Templates/macostest/csharp/.template.config/localize/templatestrings.en.json.lcl |
No specific finding. |
macios/Localize/loc/ru/macios/dotnet/Templates/Microsoft.MacCatalyst.Templates/maccatalysttest/csharp/.template.config/localize/templatestrings.en.json.lcl |
No specific finding. |
macios/Localize/loc/ru/macios/dotnet/Templates/Microsoft.iOS.Templates/iostest/csharp/.template.config/localize/templatestrings.en.json.lcl |
No specific finding. |
macios/Localize/loc/pt-BR/macios/dotnet/Templates/Microsoft.tvOS.Templates/tvostest/csharp/.template.config/localize/templatestrings.en.json.lcl |
No specific finding. |
macios/Localize/loc/pt-BR/macios/dotnet/Templates/Microsoft.tvOS.Templates/tvoslib/csharp/.template.config/localize/templatestrings.en.json.lcl |
No specific finding. |
macios/Localize/loc/pt-BR/macios/dotnet/Templates/Microsoft.tvOS.Templates/tvosbinding/csharp/.template.config/localize/templatestrings.en.json.lcl |
No specific finding. |
macios/Localize/loc/pt-BR/macios/dotnet/Templates/Microsoft.macOS.Templates/macosbinding/csharp/.template.config/localize/templatestrings.en.json.lcl |
No specific finding. |
macios/Localize/loc/pt-BR/macios/dotnet/Templates/Microsoft.MacCatalyst.Templates/maccatalysttest/csharp/.template.config/localize/templatestrings.en.json.lcl |
No specific finding. |
macios/Localize/loc/pt-BR/macios/dotnet/Templates/Microsoft.iOS.Templates/iostest/csharp/.template.config/localize/templatestrings.en.json.lcl |
No specific finding. |
macios/Localize/loc/pt-BR/macios/dotnet/Templates/Microsoft.iOS.Templates/ioslib/csharp/.template.config/localize/templatestrings.en.json.lcl |
No specific finding. |
macios/Localize/loc/pt-BR/macios/dotnet/Templates/Microsoft.iOS.Templates/iosbinding/csharp/.template.config/localize/templatestrings.en.json.lcl |
No specific finding. |
macios/Localize/loc/ja/macios/dotnet/Templates/Microsoft.tvOS.Templates/tvostest/csharp/.template.config/localize/templatestrings.en.json.lcl |
No specific finding. |
macios/Localize/loc/ja/macios/dotnet/Templates/Microsoft.macOS.Templates/macostest/csharp/.template.config/localize/templatestrings.en.json.lcl |
No specific finding. |
macios/Localize/loc/ja/macios/dotnet/Templates/Microsoft.MacCatalyst.Templates/maccatalysttest/csharp/.template.config/localize/templatestrings.en.json.lcl |
No specific finding. |
macios/Localize/loc/ja/macios/dotnet/Templates/Microsoft.iOS.Templates/iostest/csharp/.template.config/localize/templatestrings.en.json.lcl |
No specific finding. |
macios/Localize/loc/it/macios/dotnet/Templates/Microsoft.tvOS.Templates/tvostest/csharp/.template.config/localize/templatestrings.en.json.lcl |
No specific finding. |
macios/Localize/loc/it/macios/dotnet/Templates/Microsoft.tvOS.Templates/tvoslib/csharp/.template.config/localize/templatestrings.en.json.lcl |
No specific finding. |
macios/Localize/loc/it/macios/dotnet/Templates/Microsoft.tvOS.Templates/tvosbinding/csharp/.template.config/localize/templatestrings.en.json.lcl |
No specific finding. |
macios/Localize/loc/it/macios/dotnet/Templates/Microsoft.macOS.Templates/macostest/csharp/.template.config/localize/templatestrings.en.json.lcl |
Moderate (3 votes): text identifies NUnit although the source uses MSTest; translate it as a macOS test project. |
macios/Localize/loc/it/macios/dotnet/Templates/Microsoft.macOS.Templates/macoslib/csharp/.template.config/localize/templatestrings.en.json.lcl |
No specific finding. |
macios/Localize/loc/it/macios/dotnet/Templates/Microsoft.macOS.Templates/macosbinding/csharp/.template.config/localize/templatestrings.en.json.lcl |
No specific finding. |
macios/Localize/loc/it/macios/dotnet/Templates/Microsoft.MacCatalyst.Templates/maccatalysttest/csharp/.template.config/localize/templatestrings.en.json.lcl |
No specific finding. |
macios/Localize/loc/it/macios/dotnet/Templates/Microsoft.iOS.Templates/iostest/csharp/.template.config/localize/templatestrings.en.json.lcl |
No specific finding. |
macios/Localize/loc/it/macios/dotnet/Templates/Microsoft.iOS.Templates/ioslib/visualbasic/.template.config/localize/templatestrings.en.json.lcl |
No specific finding. |
macios/Localize/loc/it/macios/dotnet/Templates/Microsoft.iOS.Templates/ioslib/csharp/.template.config/localize/templatestrings.en.json.lcl |
No specific finding. |
macios/Localize/loc/it/macios/dotnet/Templates/Microsoft.iOS.Templates/iosbinding/csharp/.template.config/localize/templatestrings.en.json.lcl |
No specific finding. |
macios/Localize/loc/fr/macios/dotnet/Templates/Microsoft.tvOS.Templates/tvostest/csharp/.template.config/localize/templatestrings.en.json.lcl |
No specific finding. |
macios/Localize/loc/de/macios/dotnet/Templates/Microsoft.tvOS.Templates/tvoslib/visualbasic/.template.config/localize/templatestrings.en.json.lcl |
No specific finding. |
macios/Localize/loc/de/macios/dotnet/Templates/Microsoft.iOS.Templates/iosbinding/csharp/.template.config/localize/templatestrings.en.json.lcl |
No specific finding. |
macios/Localize/loc/cs/macios/dotnet/Templates/Microsoft.tvOS.Templates/tvostest/csharp/.template.config/localize/templatestrings.en.json.lcl |
No specific finding. |
macios/Localize/loc/cs/macios/dotnet/Templates/Microsoft.tvOS.Templates/tvoslib/visualbasic/.template.config/localize/templatestrings.en.json.lcl |
Nit (3 votes): correct Knihona to Knihovna. |
macios/Localize/loc/cs/macios/dotnet/Templates/Microsoft.tvOS.Templates/tvoslib/csharp/.template.config/localize/templatestrings.en.json.lcl |
Nit (3 votes): correct Knihona to Knihovna. |
macios/Localize/loc/cs/macios/dotnet/Templates/Microsoft.tvOS.Templates/tvosbinding/csharp/.template.config/localize/templatestrings.en.json.lcl |
No specific finding. |
macios/Localize/loc/cs/macios/dotnet/Templates/Microsoft.macOS.Templates/macostest/csharp/.template.config/localize/templatestrings.en.json.lcl |
No specific finding. |
macios/Localize/loc/cs/macios/dotnet/Templates/Microsoft.macOS.Templates/macoslib/visualbasic/.template.config/localize/templatestrings.en.json.lcl |
Nit (3 votes): correct Knihona to Knihovna. |
macios/Localize/loc/cs/macios/dotnet/Templates/Microsoft.macOS.Templates/macoslib/csharp/.template.config/localize/templatestrings.en.json.lcl |
Nit (3 votes): correct Knihona to Knihovna. |
macios/Localize/loc/cs/macios/dotnet/Templates/Microsoft.macOS.Templates/macosbinding/csharp/.template.config/localize/templatestrings.en.json.lcl |
No specific finding. |
macios/Localize/loc/cs/macios/dotnet/Templates/Microsoft.MacCatalyst.Templates/maccatalysttest/csharp/.template.config/localize/templatestrings.en.json.lcl |
No specific finding. |
macios/Localize/loc/cs/macios/dotnet/Templates/Microsoft.iOS.Templates/iostest/csharp/.template.config/localize/templatestrings.en.json.lcl |
No specific finding. |
macios/Localize/loc/cs/macios/dotnet/Templates/Microsoft.iOS.Templates/ioslib/visualbasic/.template.config/localize/templatestrings.en.json.lcl |
Nit (3 votes): correct Knihona to Knihovna. |
macios/Localize/loc/cs/macios/dotnet/Templates/Microsoft.iOS.Templates/ioslib/csharp/.template.config/localize/templatestrings.en.json.lcl |
Nit (3 votes): correct Knihona to Knihovna. |
macios/Localize/loc/cs/macios/dotnet/Templates/Microsoft.iOS.Templates/iosbinding/csharp/.template.config/localize/templatestrings.en.json.lcl |
No specific finding. |
Review details
Suppressed comments (1)
macios/Localize/loc/zh-Hans/macios/dotnet/Templates/Microsoft.tvOS.Templates/tvostest/csharp/.template.config/localize/templatestrings.en.json.lcl:2
- ❌ Codebase conventions — These are generated non-English
.lclartifacts; the repository review rules require localization changes to be made in the English.resxsources and prohibit editing.lclfiles. Please move the source changes to the appropriate English resource/template inputs and let the localization pipeline regenerate these files.
- Files reviewed: 173/173 changed files
- Comments generated: 9
- Review effort level: Lite
| <Str Cat="Text"> | ||
| <Val><![CDATA[macOS Test Project]]></Val> | ||
| <Tgt Cat="Text" Stat="Loc" Orig="New"> | ||
| <Val><![CDATA[Progetto di test NUnit]]></Val> |
| <Str Cat="Text"> | ||
| <Val><![CDATA[iOS Class Library]]></Val> | ||
| <Tgt Cat="Text" Stat="Loc" Orig="New"> | ||
| <Val><![CDATA[Knihona tříd iOS]]></Val> |
| <Str Cat="Text"> | ||
| <Val><![CDATA[iOS Class Library]]></Val> | ||
| <Tgt Cat="Text" Stat="Loc" Orig="New"> | ||
| <Val><![CDATA[Knihona tříd iOS]]></Val> |
| <Str Cat="Text"> | ||
| <Val><![CDATA[macOS Class Library]]></Val> | ||
| <Tgt Cat="Text" Stat="Loc" Orig="New"> | ||
| <Val><![CDATA[Knihona tříd macOS]]></Val> |
| <Str Cat="Text"> | ||
| <Val><![CDATA[macOS Class Library]]></Val> | ||
| <Tgt Cat="Text" Stat="Loc" Orig="New"> | ||
| <Val><![CDATA[Knihona tříd macOS]]></Val> |
| <Str Cat="Text"> | ||
| <Val><![CDATA[tvOS Class Library]]></Val> | ||
| <Tgt Cat="Text" Stat="Loc" Orig="New"> | ||
| <Val><![CDATA[Knihona tříd tvOS]]></Val> |
| <Str Cat="Text"> | ||
| <Val><![CDATA[tvOS Class Library]]></Val> | ||
| <Tgt Cat="Text" Stat="Loc" Orig="New"> | ||
| <Val><![CDATA[Knihona tříd tvOS]]></Val> |
| <Cmt Name="LcxAdmin" /> | ||
| <Cmt Name="Rccx" /> | ||
| </OwnedComments> | ||
| <Settings Name="@vsLocTools@\default.lss" Type="Lss" /> |
| <Str Cat="Text"> | ||
| <Val><![CDATA[tvOS Binding Library]]></Val> | ||
| <Tgt Cat="Text" Stat="Loc" Orig="New"> | ||
| <Val><![CDATA[tviOS 绑定库]]></Val> |
Collaborator
✅ API diff for current PR / commitNET (empty diffs)✅ API diff vs stableNET (empty diffs)ℹ️ Generator diffGenerator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes) Pipeline on Agent |
Collaborator
🔥 [CI Build #996cddf] Test results 🔥Test results❌ Tests failed on VSTS: test results 0 tests crashed, 1 tests failed, 263 tests passed. Failures❌ monotouch tests (iOS)1 tests failed, 24 tests passed.Failed tests
Html Report (VSDrops) Download Successes✅ assembly-processing: All 1 tests passed. Html Report (VSDrops) Download macOS tests✅ Tests on macOS Sonoma (14): All 5 tests passed. Html Report (VSDrops) Download Linux Build VerificationPipeline on Agent |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LEGO: Pull request from lego/hb_5df43909-4a19-4f55-bc3f-9ea8fccf3c82_20260917175401680 to main with localized lcls