LEGO: Pull request from lego/hb_5df43909-4a19-4f55-bc3f-9ea8fccf3c82_20260916175308982 to main - #26648
LEGO: Pull request from lego/hb_5df43909-4a19-4f55-bc3f-9ea8fccf3c82_20260916175308982 to main#26648csigs wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
🟡 Changes recommended
Unresolved localization issues and the generated .lcl workflow concern remain.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
Adds and updates localized .lcl entries for new mtouch, binding, registrar, and MSBuild diagnostics across supported locales.
Changes:
- Adds translations for new diagnostic keys.
- Updates BindAs, Xcode-selection, deployment, manifest, and resource-package messages.
- Refreshes localized metadata and existing wording.
File summaries
| File | Summary |
|---|---|
macios/Localize/loc/zh-Hant/macios/tools/mtouch/Errors.resx.lcl |
Traditional Chinese mtouch diagnostics; generated .lcl workflow concern applies. |
macios/Localize/loc/zh-Hant/macios/src/Resources.resx.lcl |
Traditional Chinese binding diagnostics. |
macios/Localize/loc/zh-Hant/macios/msbuild/Xamarin.Localization.MSBuild/MSBStrings.resx.lcl |
Traditional Chinese MSBuild diagnostics. |
macios/Localize/loc/zh-Hans/macios/tools/mtouch/Errors.resx.lcl |
Simplified Chinese mtouch diagnostics. |
macios/Localize/loc/zh-Hans/macios/src/Resources.resx.lcl |
Simplified Chinese binding diagnostics. |
macios/Localize/loc/zh-Hans/macios/msbuild/Xamarin.Localization.MSBuild/MSBStrings.resx.lcl |
Simplified Chinese MSBuild diagnostics. |
macios/Localize/loc/tr/macios/tools/mtouch/Errors.resx.lcl |
Turkish mtouch diagnostics. |
macios/Localize/loc/tr/macios/src/Resources.resx.lcl |
Turkish binding diagnostics. |
macios/Localize/loc/tr/macios/msbuild/Xamarin.Localization.MSBuild/MSBStrings.resx.lcl |
Turkish MSBuild diagnostics. |
macios/Localize/loc/ru/macios/tools/mtouch/Errors.resx.lcl |
Russian mtouch diagnostics. |
macios/Localize/loc/ru/macios/src/Resources.resx.lcl |
Russian binding diagnostics. |
macios/Localize/loc/ru/macios/msbuild/Xamarin.Localization.MSBuild/MSBStrings.resx.lcl |
Russian MSBuild diagnostics; nit-level punctuation and spacing issue remains. |
macios/Localize/loc/pt-BR/macios/tools/mtouch/Errors.resx.lcl |
Brazilian Portuguese mtouch diagnostics. |
macios/Localize/loc/pt-BR/macios/src/Resources.resx.lcl |
Brazilian Portuguese binding diagnostics. |
macios/Localize/loc/pt-BR/macios/msbuild/Xamarin.Localization.MSBuild/MSBStrings.resx.lcl |
Brazilian Portuguese MSBuild diagnostics; nit-level verbosity wording issue remains. |
macios/Localize/loc/pl/macios/tools/mtouch/Errors.resx.lcl |
Polish mtouch diagnostics. |
macios/Localize/loc/pl/macios/msbuild/Xamarin.Localization.MSBuild/MSBStrings.resx.lcl |
Polish MSBuild diagnostics. |
macios/Localize/loc/ko/macios/tools/mtouch/Errors.resx.lcl |
Korean mtouch diagnostics. |
macios/Localize/loc/ko/macios/src/Resources.resx.lcl |
Korean binding diagnostics. |
macios/Localize/loc/ko/macios/msbuild/Xamarin.Localization.MSBuild/MSBStrings.resx.lcl |
Korean MSBuild diagnostics. |
macios/Localize/loc/ja/macios/tools/mtouch/Errors.resx.lcl |
Japanese mtouch diagnostics. |
macios/Localize/loc/ja/macios/src/Resources.resx.lcl |
Japanese binding diagnostics. |
macios/Localize/loc/ja/macios/msbuild/Xamarin.Localization.MSBuild/MSBStrings.resx.lcl |
Japanese MSBuild diagnostics; moderate placeholder-mapping issue remains. |
macios/Localize/loc/it/macios/tools/mtouch/Errors.resx.lcl |
Italian mtouch diagnostics. |
macios/Localize/loc/it/macios/src/Resources.resx.lcl |
Italian binding diagnostics. |
macios/Localize/loc/fr/macios/tools/mtouch/Errors.resx.lcl |
French mtouch diagnostics. |
macios/Localize/loc/fr/macios/src/Resources.resx.lcl |
French binding diagnostics. |
macios/Localize/loc/fr/macios/msbuild/Xamarin.Localization.MSBuild/MSBStrings.resx.lcl |
French MSBuild diagnostics; nit-level grammar issue remains. |
macios/Localize/loc/es/macios/tools/mtouch/Errors.resx.lcl |
Spanish mtouch diagnostics. |
macios/Localize/loc/es/macios/src/Resources.resx.lcl |
Spanish binding diagnostics; nit-level translation issue remains. |
macios/Localize/loc/es/macios/msbuild/Xamarin.Localization.MSBuild/MSBStrings.resx.lcl |
Spanish MSBuild diagnostics. |
macios/Localize/loc/de/macios/src/Resources.resx.lcl |
German binding diagnostics. |
macios/Localize/loc/cs/macios/tools/mtouch/Errors.resx.lcl |
Czech mtouch diagnostics. |
macios/Localize/loc/cs/macios/src/Resources.resx.lcl |
Czech binding diagnostics. |
macios/Localize/loc/cs/macios/msbuild/Xamarin.Localization.MSBuild/MSBStrings.resx.lcl |
Czech MSBuild diagnostics. |
Review details
Suppressed comments (2)
macios/Localize/loc/pt-BR/macios/msbuild/Xamarin.Localization.MSBuild/MSBStrings.resx.lcl:1262
⚠️ error_message — This translation repeats “mais detalhes” and says to rebuild “with more details,” which does not clearly convey the source instruction to increase verbosity. Replace it with a translation that tells the user to rebuild with increased detail/verbosity.
<Val><![CDATA[Falha na tarefa PrepareAssemblies sem relatar um erro específico. Reconstrua com mais detalhes para obter mais detalhes.]]></Val>
macios/Localize/loc/ru/macios/msbuild/Xamarin.Localization.MSBuild/MSBStrings.resx.lcl:2807
⚠️ spelling — This Russian translation has a stray comma and missing spaces around the assembly placeholder (сборке'{1}'), making the diagnostic malformed. Keep{0}as the resource,{1}as the assembly, and{2}as the extraction path.
<Val><![CDATA[Ресурс, '{0}' в сборке'{1}' будет извлечен в '{2}', находящийся за пределами целевого каталога '{3}'.]]></Val>
- Files reviewed: 37/37 changed files
- Comments generated: 4
- Review effort level: Lite
| <Str Cat="Text"> | ||
| <Val><![CDATA[Ignoring the metadata '{0}' for the native reference '{1}' in the binding resource package '{2}': this metadata is computed by the build and can't be set in a binding resource package manifest.]]></Val> | ||
| <Tgt Cat="Text" Stat="Loc" Orig="New"> | ||
| <Val><![CDATA[バインド リソース パッケージ '{1}' のメタデータ '{0}' を無視しています '{2}': このメタデータはビルドによって計算されるため、バインド リソース パッケージ マニフェストで設定することはできません。]]></Val> |
| <Str Cat="Text"> | ||
| <Val><![CDATA[The [FactoryMethod]5D; binding method '{0}.{1}' has an 'out NSError' parameter, but its return value is not nullable. Add [return: NullAllowed]5D; to the binding method so the generated factory method can return null when the native initializer fails.]]></Val> | ||
| <Tgt Cat="Text" Stat="Loc" Orig="New"> | ||
| <Val><![CDATA[El método de enlace [FactoryMethod]5D; "{0}.{1}" tiene un parámetro "out NSError", pero su valor devuelto no admite valores NULL. Agregue [return: NullAllowed]5D; al método de enlace para que el método de generador generado pueda devolver NULL cuando se produce un error en el inicializador nativo.]]></Val> |
| <Str Cat="Text"> | ||
| <Val><![CDATA[The resource '{0}' in assembly '{1}' would extract to '{2}' which is outside of the target directory '{3}'.]]></Val> | ||
| <Tgt Cat="Text" Stat="Loc" Orig="New"> | ||
| <Val><![CDATA[La ressource '{0}' dans l’assembly que '{1}' extrait vers '{2}' qui se trouve en dehors du '{3}' du répertoire cible.]]></Val> |
| </Str> | ||
| <Disp Icon="Str" /> | ||
| </Item> | ||
| <Item ItemId=";MT4192" ItemType="0;.resx" PsrId="211" Leaf="true"> |
✅ API diff for current PR / commitNET (empty diffs)✅ API diff vs stableNET (empty diffs)ℹ️ Generator diffGenerator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes) Pipeline on Agent |
🚀 [CI Build #19cb080] Test results 🚀Test results✅ All tests passed on VSTS: test results. 🎉 All 264 tests passed 🎉 Tests counts✅ assembly-processing: All 1 tests passed. Html Report (VSDrops) Download macOS tests✅ Tests on macOS Sonoma (14): All 5 tests passed. Html Report (VSDrops) Download Linux Build VerificationPipeline on Agent |
LEGO: Pull request from lego/hb_5df43909-4a19-4f55-bc3f-9ea8fccf3c82_20260916175308982 to main with localized lcls