Various antigen improvements - #442
Open
dhartglassMSFT wants to merge 2 commits into
Open
dhartglassMSFT wants to merge 2 commits into
dhartglassMSFT wants to merge 2 commits into
Conversation
add a method StableHash and call that instead of GethashCode to make the repros easier to work with fix test bucketing float to int reinterpret off by default. Reduce float allbitsset probability reflect over core_root so we get up to date intrinsics have trimmer use up to date corerun remove lazy initialization of metadata paths fix indexing into single element vectors clean up comments reword comments. add logging for unresolved types. remove HasByRefParameter clean up some comments fixup another comment
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some fixes to some issues in the pipeline, and to make Antigen produce more useful testcases
Pipeline improvements
MetadataLoadContextto load methods from the supplied Core_Root.*GetHashCode()which is only stable per process. This wasn't "broken", because base+diff runs both executed ion the same process, but this should make these repros much easier to work with.Testcase improvements
*.AllBitsSet()(NaN) on floating point vectors from 50% to 5%. Hopefully not having NaN everywhere will make for more interesting computations.