Skip to content

MessagePack: Android device support for the Java client - #37759

Merged
guardrex merged 8 commits into
mainfrom
guardrex/java-api-version-information
Oct 2, 2026
Merged

guardrex merged 8 commits into
mainfrom
guardrex/java-api-version-information

Conversation

@guardrex

@guardrex guardrex commented Oct 1, 2026 •

Copy link
Copy Markdown
Collaborator

Fixes #37757

Cross-references for review:

Brennan ... I use general language and avoided versioning the remarks because it sounds like a general issue that's probably going to happen again in the future. If this is a one-time scenario, do you want this subsection versioned for .NET 8 and .NET 9?


Internal previews

File Preview link
aspnetcore/signalr/java-client.md Learn preview
aspnetcore/signalr/messagepackhubprotocol.md Learn preview

Build report

@guardrex guardrex self-assigned this Oct 1, 2026

This comment was marked as resolved.

Co-authored-by: guardrex <1622880+guardrex@users.noreply.github.com>
@BrennanConroy

Copy link
Copy Markdown
Member

That's a lot 😆
I would prefer something shorter and having some specifics is ok.
See https://learn.microsoft.com/en-us/aspnet/core/signalr/java-client?view=aspnetcore-10.0#android-development-notes where we talk about the general API version support.

A small section mentioning the current known API version as well as a reference to the underlying dependencies would probably be fine?

@guardrex

guardrex commented Oct 1, 2026

Copy link
Copy Markdown
Collaborator Author

It was shorter, and then Copilot decided to make it longer with more detail. 🙈

I'll try again tomorrow (Friday) morning for a shorter book 📖 on it 😄 and ping u back.

@guardrex

guardrex commented Oct 2, 2026 •

Copy link
Copy Markdown
Collaborator Author

@BrennanConroy ... I distilled it down to the main points, and we can just use the PU repo issue cross-link because it has a detailed explanation. I left the language general to cover future instances of this situation, but I also left the specific example in place to help the reader understand the dependency and its Android API restriction.

I also cross-link from the main Java client article section that you mentioned and fixed some future tense there and casing ("Java Client" 👉 "Java client"). The cross-link requires all versions of the content in the MessagePack article to receive the section. The downside is that ...

  • It wasn't a reported problem prior to that PU issue arriving in the .NET 8-9 era.
  • The section's example refers to 8.x era packages in content focused on < .NET 8's release.

Still tho, it makes the general points clear and the vast majority of devs are looking at our current release docs. If you don't like that cross-linking, I can back it out and remove the new section in <6.0 content from the MessagePack article.

Ugh! 🤦‍♂️ The copying of content over-and-over in the repo is costly to maintain. I suggested to the team not to do it for a few reaons, but they went ahead. Now, there's duplicate content all over the place, except in the Blazor node where someone ... cough cough 🦖 cough ... avoided it like the plague. 😆

@guardrex
guardrex merged commit 99ab72b into main Oct 2, 2026
5 checks passed
@guardrex
guardrex deleted the guardrex/java-api-version-information branch October 2, 2026 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add java API version information to MessagePack section

4 participants