Skip to content

refactor(teams_selection): centralize team selection in TeamSelectionService - #592

Open
sawankshrma wants to merge 1 commit into
devsecopsmaturitymodel:mainfrom
sawankshrma:global_team_selection
Open

refactor(teams_selection): centralize team selection in TeamSelectionService#592
sawankshrma wants to merge 1 commit into
devsecopsmaturitymodel:mainfrom
sawankshrma:global_team_selection

Conversation

@sawankshrma

Copy link
Copy Markdown
Collaborator

Adds a TeamSelectionService as the single source of truth for the active team filter, used by the heatmap, report page/modal, and evidence components. Removes selectedTeams from ReportConfig (previously stored inside localStorage, now only persists per-session)

Changes:

  • TeamSelectionService has selectedTeams, effectiveTeams, selectedGroupName, and isAllSelected as computed signals.
  • CircularHeatmapComponent: derives fiiltersTeams/filtersTeamGroups from the service; syncs SectorService via effect()
  • ReportComponent/ReportConfigModalComponent: selectedTeams is pulled out of ReportConfig entirely. Team selection now flows through the service instead of being persisted config. The modal's result type changed from ReportConfig to { config, selectedTeams } since they're no longer the same object.
  • AddEvidenceModalComponent/EvidencePanelComponent: injects service directly instead of passing allTeams/teamGroups through dialog data
  • TeamSelectorComponent: makes selectedTeams a plain input, selectAllTeams()/deselectAllTeams()/selectGroup() just emit rather than mutate local state.

@sawankshrma
sawankshrma requested a review from vbakke September 7, 2026 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant