feat: allow setting custom WebRTC field trials on PeerConnectionFactory - #284
Merged
Conversation
Add PeerConnectionFactory constructor overloads that accept a Map<String, String> of field trials, forwarded to the native factory as a FieldTrialsView so callers can enable experimental WebRTC features (e.g. message interleaving) without touching native code. webrtc::FieldTrials (api/field_trials.h) isn't used on the native side because its translation unit isn't linked into the webrtc archive for every build configuration of this project; a small FieldTrialsView backed directly by the passed-in map avoids that dependency. Resolves #216
devopvoid
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PeerConnectionFactoryconstructor overloads accepting aMap<String, String>of field trials, forwarded to the native factory as awebrtc::FieldTrialsViewso callers can enable experimental WebRTC features (e.g. message interleaving) without touching native code.jni::FieldTrialsView(native,include/api/FieldTrialsView.h+src/api/FieldTrialsView.cpp) backed directly by the passed-in map, sincewebrtc::FieldTrials(api/field_trials.h) isn't linked into thewebrtcarchive for every build configuration of this project.docs/guide/advanced/field-trials.md) and tests covering valid, empty, and invalid field trial maps.Resolves #216
Test plan
mvn -pl webrtc-jni package -DskipTests— native build succeeds and linksmvn -pl webrtc test -Dtest=PeerConnectionFactoryTests— 16/16 passmvn -pl webrtc test(full module suite) — 148/148 pass