#2401: Rework Mainwindow

[samuelkos17]

This PR fixes #2401 #2402 #2433

Implemented changes:

This is quite a huge PR that completely reworked our GUI architecture, the most important changes:

• Reworked the GUI from "MVC" to MVVM
• Split the MainController into single modules (NavigationPanel, IdeLauncherTab)
• Introduced Tabs
• Introduced an EventBus
• Removed any logic from the .fxml files
• Introduced Services & Factories
• Refactored the folder structure of the GUI
  • Regarding the terminology of the new folder structure:
    • Factory: Creates ViewModels & Views while containing the necessary services to do so. Initialized in App
    • Service: Encapsulates business logic and access to data or functionality independently of the UI. Initialized in App
    • Control: A self-contained UI component of the MainWindow. Extracted frm MainWindowView to improve maintainability and seperation of concerns, where introducing a dedicated View/ViewModel split would not be worthwile.
    • View: The actual UI representation without business logic. Its responsibility is to display data nd information from the ViewModel through bindings.
    • ViewModel: Acts as a bridge between the View and the Services/Factory/Data layer. It maintains the current state and contains the UI-related logic.

The Refactoring-Work isn't done with this PR though, every functionality we had before (besides the language selection) is also present in the new GUI, but the GUI architecture is still not clean enough and there are a few hacks/smells in the code that still need to be reworked. In order to not bloat this PR even further the next tasks are listed here:

• Rework/Reintroduce language selection Overhaul language selection logic #2214
• Implement Alert & Dialog Factorys Implement PopUps, PopUp base classes, PopUpFactory for the GUI #2439
• Rework the console handling Rework Console to MVVM #2400
• Update GUI Docu Add documentation for contributing to the GUI #2107,
• Implement an EventBus/EventListeners, especially to remove the weird TabPane attaching in the TabFactory Consider adding an EventBus to the new GUI #2433

---

Testing instructions

Please add conscise, understandable instructions on how a reviewer can test/verify the functionality of your contribution here:

1. Run ide gui using the local dev build and test if everything works.

---

Checklist for this PR

Make sure everything is checked before merging this PR. For further info please also see
our DoD.

• When running mvn clean test locally all tests pass and build is successful
• PR title is of the form #«issue-id»: «brief summary» (e.g. #921: fixed setup.bat and not feature/921 fixed setup.bat). If no issue ID exists, title only.
• PR top-level comment summaries what has been done and contains link to addressed issue(s)
• PR and issue(s) have suitable labels
• Issue is set to In Progress and assigned to you or there is no issue (might happen for very small PRs)
• You followed all coding conventions
• You have added the issue implemented by your PR in CHANGELOG.adoc unless issue is labelled
  with internal
• You have not changed any dependency in pom.xml files or otherwise if runtime dependencies changed, you have updated our LICENSE.asciidoc
• You have formulated clear instructions on how to test your contribution under "Testing instructions"

[coveralls]

Coverage Report for CI Build 35987805879

Warning

Build has drifted: This PR's base is out of sync with its target branch, so coverage data may include unrelated changes.
Quick fix: rebase this PR. Learn more →

Coverage increased (+0.2%) to 74.339%

Details

• Coverage increased (+0.2%) from the base build.
• Patch coverage: No coverable lines changed in this PR.
• 24 coverage regressions across 3 files.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

24 previously-covered lines in 3 files lost coverage.

File	Lines Losing Coverage	Coverage
com/devonfw/ide/gui/App.java	22	0.0%
com/devonfw/tools/ide/tool/ide/IdeToolCommandlet.java	1	87.58%
com/devonfw/tools/ide/version/VersionSegment.java	1	91.08%

---

Coverage Stats

Relevant Lines:	19288
Covered Lines:	14989
Line Coverage:	77.71%
Relevant Branches:	8567
Covered Branches:	5718
Branch Coverage:	66.74%
Branches in Coverage %:	Yes
Coverage Strength:	3.33 hits per line

---

💛 - Coveralls

[laim2003]

Thanks for the deep rework! It looks way better already. The architecture is now much cleaner and allows for other features to be built on top. Regarding the TabFactory/general Tab architecture I had some optimization ideas that we should think about. But anyways good work!

[laim2003]

Thanks for your work👍 Just changed this to approve so the merge is not blocked

[laim2003]

Looks good, thanks

[hohwille]

@samuelkos17 thanks for your PR.
I very much like your work and can already see that we achieve the lose-coupling and more modular and maintainable code this way. Great work 👍
I focused on two things that we should rather get aligned also now and not when tons of screens (aka dialogs) have been implemented (and need to be refactored):

• packaging layout
• dependency management to access technical components (required almost everywhere like e.g. NlsService alongside with our famous IdeContext. Just think to add another such dependency in the future. You will have to add it to many constructors everywhere causing quite some refactoring that we maybe can avoid.

[hohwille]

@samuelkos17 thanks for the update. For me all looks good now and I would consider this as ready to merge. 👍
Maybe we should wait until the release is through but if nobody else has concerns we should then finally merge to open the road for follow-up changes.

[samuelkos17]

@hohwille yes we can wait til the release is done. While updating my review for the docu in #2291 I've also realized that I didn't use the guiStateManager god-object everywhere and still had a few useless parameters in constructors so I cleaned that up and pushed it. It's only a small change and IMHO you don't really need to look at it.