check _console_buffer against current console destbuffer - #270
Open
Naim2000 wants to merge 1 commit into
Open
Conversation
Member
|
imo a better fix would be for what do you think @fincs ? |
Member
|
Note that the exception dump screen happens from within exception context, and therefore it is not allowed to call malloc/free. I'd suggest simply setting the pointer to null. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the issue where using normal CON_Init after using CON_InitEx makes the system continue printing on the Ex buffer. which is a weird use case, but is effectively what happens when the exception handler is called
(warning: this is a kind of bandaid fix, because I am not trying to refactor the other half of console in a single pr)