common-utils: Make sudoers configuration optional - #1723
Open
Daniel Weuthen (weuthen-sipgate) wants to merge 2 commits into
Open
common-utils: Make sudoers configuration optional#1723Daniel Weuthen (weuthen-sipgate) wants to merge 2 commits into
Daniel Weuthen (weuthen-sipgate) wants to merge 2 commits into
Conversation
Daniel Weuthen (weuthen-sipgate)
requested a review
from a team
as a code owner
September 1, 2026 18:23
Author
|
@microsoft-github-policy-service agree company="sipgate" |
|
Daniel Weuthen (@weuthen-sipgate) the command you issued was incorrect. Please try again. Examples are: and |
Author
|
@microsoft-github-policy-service agree company="sipgate" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds a new configurable option to the
common-utilsfeature that allows users to control whether a non-root user is added to the passwordless sudoers list. By default, this option is enabled, but it can now be disabled if desired. The changes include updates to documentation, feature configuration, implementation logic, and new tests to verify both enabled and disabled scenarios.Feature enhancement:
sudoersboolean option todevcontainer-feature.json, allowing users to specify whether the non-root user should be added to passwordless sudoers (defaults totrue).README.mdto describe the newsudoersoption.common-utilsfeature version to2.6.0to reflect the new functionality.Implementation update:
main.shto respect the newSUDOERSenvironment variable and conditionally add the non-root user to the sudoers file only if the option is enabled. [1] [2]Testing improvements:
sudoers-trueandsudoers-false) to verify the correct behavior of thesudoersoption, ensuring the sudoers file is created or omitted as expected. [1] [2] [3]