Fix MSI version display bugs - #6
Merged
Merged
Conversation
- Add ARPDISPLAYVERSION property set to the full semver
(MsiPackageVersion) so Windows Add/Remove Programs shows e.g.
'0.1.0-beta.1' instead of the ICE24-stripped numeric-only
ProductVersion ('0.1.0').
- Pass -p:Version=$(MsiPackageVersion) to the isolated nested
'dotnet publish' Exec command in the wixproj so the exe embedded
in the MSI is actually stamped with the release version instead
of falling back to the csproj's hardcoded default (0.0.0).
- Expose MsiPackageVersion as a WiX preprocessor variable alongside
ProductVersion via DefineConstants.
Verified locally: built the MSI with ProductVersion=0.1.0 and
MsiPackageVersion=0.1.0-beta.1, confirmed the embedded exe reports
ProductVersion 0.1.0-beta.1+<sha> and the MSI's ARPDISPLAYVERSION
property is 0.1.0-beta.1.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
🟢 Approval recommended
The changes are small, internally consistent, and directly address the stated MSI version display/root-cause issues without introducing risky behavior.
Pull request overview
This PR fixes MSI version reporting so Windows “Add/Remove Programs” shows the full SemVer (including prerelease suffix) and the installed app binary embedded in the MSI reports the correct release version instead of the csproj default.
Changes:
- Add
ARPDISPLAYVERSIONto the WiX package so ARP UI displays the full$(MsiPackageVersion)rather than the ICE24-strippedProductVersion. - Expose both
ProductVersionandMsiPackageVersiontoPackage.wxsviaDefineConstants. - Pass
-p:Version=$(MsiPackageVersion)into the isolateddotnet publishso the embedded EXE carries the intended version.
File summaries
| File | Description |
|---|---|
| src/DemaConsulting.AgentControl.Msi/Package.wxs | Sets ARPDISPLAYVERSION to ensure ARP displays the full SemVer string. |
| src/DemaConsulting.AgentControl.Msi/DemaConsulting.AgentControl.Msi.wixproj | Plumbs MsiPackageVersion into WiX constants and into the nested publish to stamp the app binary version. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Two bugs reported after installing a real 0.1.0-beta.1 MSI:
Root cause