Conversation
The desktop build's node-bundle guard correctly rejected Bun.write/Bun.file in the five migration server modules (they ride the maintenance handlers into the sidecar bundle); switch them to node:fs/promises, which is the sidecar's runtime contract. The arm64 Windows preinstall ran npm at the repo root, where the workspace's catalog: protocol is an unsupported URL type for npm. Install into an empty RUNNER_TEMP prefix instead (npm then ignores every package.json) and copy the platform packages into the root node_modules where electron-builder's os/cpu filter already picks them up.
|
This PR doesn't fully meet our contributing guidelines and PR template. What needs to be fixed:
Please edit this PR description to address the above within 2 hours, or it will be automatically closed. If you believe this was flagged incorrectly, please let a maintainer know. |
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
|
This pull request has been automatically closed because it was not updated to meet our contributing guidelines within the 2-hour window. Feel free to open a new pull request that follows our guidelines. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #126
Type of change
What does this PR do?
The 2.0.1 desktop build fails because five migration services use Bun file APIs in the Node sidecar bundle, and the Windows arm64 npm preinstall reads the workspace root's unsupported
catalog:dependencies. This change usesnode:fs/promisesin those services and installs the arm64 packages under an empty temporary prefix before copying them intonode_modules.How did you verify your code works?
packages/desktop bun run prebuildcompleted locally. The pull request's desktop build and test checks are the release gate.Screenshots / recordings
Not applicable; this changes build behavior.
Checklist