[pod-reloader] Scan only the real release line and scan every release tag - #32
Open
Glitchy-Sheep wants to merge 3 commits into
Open
Glitchy-Sheep wants to merge 3 commits into
Glitchy-Sheep wants to merge 3 commits into
Conversation
The regular scan takes the latest patch of the N newest release lines (major.minor) from the prod registry. The module has one line, 1.0, on every release channel, but the registry also holds v0.1.0 and v0.2.0: one image from July 2025 that is not a release and carries 59 open CVEs. With N=3 the scan picks it up, and every scheduled run and push to main ends red while main and v1.0.14 are clean. Set N to 1 and document when to raise it. Signed-off-by: Roman Berezkin <roman.berezkin@flant.com>
Contributor
Author
|
Verified on this branch:
For comparison, the last regular scan on main with N=3 (https://github.com/deckhouse/pod-reloader/actions/runs/35209203758) scanned |
The vulnerability remediation regulation (section 6.1) requires a scan when a release tag is created. The scan workflow now also runs when "Build and push for prod" finishes successfully, takes the built tag as source_tag and scans only that tag. Waiting for the build instead of the tag push keeps the scan from starting before the image reaches the prod registry: the build takes about 15 minutes. Signed-off-by: Roman Berezkin <roman.berezkin@flant.com>
GitHub renders an expression in a job name unevaluated when the job is skipped, so PR check lists showed the raw expression. The release scan is told apart by its workflow_run event instead. Signed-off-by: Roman Berezkin <roman.berezkin@flant.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
.github/workflows/trivy_image_check.yaml:latest_releases_amountdefault3->1. A comment says when to raise it.PR scans, schedule, secrets and the action version stay as in #30.
Why do we need it, and what problem does it solve?
Regular scan is red on every run
major.minorlines found in the prod registry.New release tags are not scanned
push: tagstrigger would race the prod build, which takes about 15 minutes. So the scan waits for that workflow to finish instead.Checklist
CI-only change. Verified on the branch: PR scan and a manual regular scan are green,
Tags to check in registry: main v1.0.14(see the comment below). The release scan cannot run before merge:workflow_runfires from the default branch only. First real run is the next release tag.