CS 1.0: SD-3258: Add isCargoOperationalCall to TransportCall

[HenrikHL]

SD-3258: Add isCargoOperationalCall to Vessel Schedules TransportCall

[qodo-code-review]

PR Summary by Qodo

Add cargo-operational flag to Vessel Schedule transport calls

✨ Enhancement 📝 Documentation 🕐 Less than 10 minutes

AI Description

• Adds an optional cargo-operational indicator to Vessel Schedule transport calls.
• Treats omitted values as true to preserve backward-compatible behavior.
• Documents filtering semantics and independence from timestamp classifiers.

Diagram

graph TD
  API["Vessel Schedules"] --> Call["TransportCall"] --> Flag{"Cargo operational?"} -->|"true or omitted"| Keep["Include call"]
  Flag -->|"false"| Filter["Filter optionally"]

Loading

High-Level Assessment

The optional boolean with a true default is appropriate for this binary filtering requirement and preserves compatibility with existing responses. A richer activity enum or operations list was considered but would add unnecessary contract complexity beyond distinguishing cargo-operational calls.

Files changed (2) +23 / -0

Enhancement (1) +15 / -0

CS_v1.0.4.yamlAdd cargo-operational indicator to TransportCall +15/-0

Add cargo-operational indicator to TransportCall

• Adds the optional boolean 'isCargoOperationalCall' property with a default of 'true'. Its contract distinguishes calls where cargo loading or discharge applies and clarifies timestamp independence, mixed-activity behavior, and consumer filtering.

cs/v1/CS_v1.0.4.yaml

Documentation (1) +8 / -0

README.mdDocument the Vessel Schedule cargo-call indicator +8/-0

Document the Vessel Schedule cargo-call indicator

• Adds v1.0.4 release notes describing the new property, omission behavior, filtering use case, and cargo-operation classification rules.

cs/v1/README.md

[qodo-code-review]

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)

Great, no issues found!

Qodo reviewed your code and found no material issues that require review

Tip of the day

💡 Did you know, you can tweak Display preferences with a live preview to see your comment before it ships

More tips ↗ | Customize Qodo ↗ | Qodo docs ↗

[Copilot]

🟡 Changes recommended

Minor but user-facing documentation wording inconsistencies/ambiguities should be corrected to avoid misinterpretation of the new field’s semantics.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Pull request overview

Adds an optional isCargoOperationalCall boolean to the Commercial Schedules (CS) API TransportCall schema (Vessel Schedules) so consumers can identify and filter out non-cargo-operational calls while keeping the full published rotation.

Changes:

• Documented the new isCargoOperationalCall semantics in the CS v1 README release notes.
• Extended the TransportCall schema in CS_v1.0.4.yaml with isCargoOperationalCall (defaulting to true when omitted) and detailed guidance for consumers.

File summaries

File	Description
cs/v1/README.md	Adds v1.0.4 release-note text describing isCargoOperationalCall and its intended interpretation.
cs/v1/CS_v1.0.4.yaml	Adds isCargoOperationalCall to TransportCall with default/description to support filtering non-cargo calls.

Review details

• Files reviewed: 2/2 changed files
• Comments generated: 2
• Review effort level: Lite

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.