Skip to content

Refactor/perf batch 10 - #707

Open
timcadman wants to merge 15 commits into
v7.0-devfrom
refactor/perf-batch-10
Open

timcadman wants to merge 15 commits into
v7.0-devfrom
refactor/perf-batch-10

Conversation

@timcadman

Copy link
Copy Markdown
Contributor

No description provided.

@timcadman
timcadman changed the base branch from v6.3.6-dev to v7.0-dev September 16, 2026 10:26
@github-actions

github-actions Bot commented Sep 18, 2026

Copy link
Copy Markdown
❌ 3 of 5 checks failed
CheckResult
Devtools checks✅ passed
Code quality❌ 1 new finding (package total: 2045)
Armadillo unit tests[ FAIL 9 | WARN 0 | SKIP 27 | PASS 12101 ]
Opal unit tests[ FAIL 8 | WARN 0 | SKIP 27 | PASS 11176 ]
Test coverageℹ️ no coverable lines changed (project: 66.8%)

Tested against dsBase versions:
Armadillo: 7.0.0.9000
Opal: 7.0.0.9000

Logs: Devtools checks · Code quality · Armadillo unit tests · Opal unit tests · Codecov

@timcadman
timcadman marked this pull request as ready for review September 18, 2026 09:37
Comment thread R/ds.rowColCalc.R

# check that the new object has been created and display a message accordingly
finalcheck <- isAssigned(datasources, newobj)
DSI::datashield.assign(datasources, newobj, call("rowColCalcDS", dataset.name=x, operation=indx))
@codecov-commenter

codecov-commenter commented Sep 18, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 66.82%. Comparing base (2384659) to head (beb7830).

Additional details and impacted files
@@             Coverage Diff              @@
##           v7.0-dev     #707      +/-   ##
============================================
+ Coverage     66.74%   66.82%   +0.08%     
============================================
  Files           142      142              
  Lines          6038     5842     -196     
============================================
- Hits           4030     3904     -126     
+ Misses         2008     1938      -70     
Flag Coverage Δ
armadillo-arg 21.24% <ø> (-0.06%) ⬇️
armadillo-misc 16.03% <ø> (-0.16%) ⬇️
armadillo-perf-1 5.99% <ø> (+0.06%) ⬆️
armadillo-perf-2 16.98% <ø> (+1.64%) ⬆️
armadillo-perf-3 15.23% <ø> (+5.03%) ⬆️
armadillo-smk-1 34.23% <ø> (+0.01%) ⬆️
armadillo-smk-2 38.03% <ø> (-0.26%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants