Conversation
…factor/perf-batch-9 # Conflicts: # .Rbuildignore # NAMESPACE # R/utils.R # dsBase_7.0.0-permissive.tar.gz
❌ 2 of 5 checks failed
Tested against Logs: Devtools checks · Code quality · Armadillo unit tests · Opal unit tests · Codecov |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
There was a problem hiding this comment.
lintr found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## v7.0-dev #704 +/- ##
============================================
+ Coverage 61.16% 66.74% +5.58%
============================================
Files 142 142
Lines 6120 6038 -82
============================================
+ Hits 3743 4030 +287
+ Misses 2377 2008 -369
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
…lient into refactor/perf-batch-9
…factor/perf-batch-9
Update "perf" test for opal and armadillo
| plot_data_merged <- rbind(plot_data_merged, plot_data[[i]]$data) | ||
| } | ||
| pt_merged <- data.table::data.table(pt_merged) | ||
| plot_data_merged <- data.table::data.table(plot_data_merged) |
timcadman
marked this pull request as ready for review
September 17, 2026 12:18
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's changed
ds.boxPlot: dropped the manualisDefined()/checkClass()connection and variable checks in favour of a singleclassDSaggregate call plus.checkClassConsistency(), which aborts ifx's class differs across studies.isDefinedandcheckClassare now enforced on the server-side.rangeDScalls inds.heatmapPlot,ds.contourPlot, andds.densityGridremain onas.symbol(paste0("rangeDS(", x, ")"))rather thancall(), asrangeDSwill be refactored in batch 10.How to test