Chore/fix ci - #703
Chore/fix ci#703
Conversation
❌ 1 of 5 checks failed
Tested against Logs: Devtools checks · Code quality · Armadillo unit tests · Opal unit tests · Codecov |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## v7.0-dev #703 +/- ##
=========================================
Coverage 60.87% 60.87%
=========================================
Files 142 142
Lines 6365 6365
=========================================
Hits 3875 3875
Misses 2490 2490
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
StuartWheater
left a comment
There was a problem hiding this comment.
- Is the failure of "Armadillo Report" job's task "Compute results & write summary" also "passed" significant?
- This doesn't appear to be the originating failure but this "reporting" job is the only one which fails, not the source task. Is this correct?
Good observations Stuart, thanks. So the 'Armadillo report' failure means one or more Armadillo tests failed (same for opal). But I agree that ideally you would see a failure on that test file too. I will have a look and ask for a re-review |
StuartWheater
left a comment
There was a problem hiding this comment.
The generated reports the behavior of test.
- (The results of "lint" test are worrying)
What's changed
Lintrto avoid false positive