Skip to content

Chore/fix ci - #703

Merged
timcadman merged 12 commits into
v7.0-devfrom
chore/fix-ci
Sep 15, 2026
Merged

timcadman merged 12 commits into
v7.0-devfrom
chore/fix-ci

Conversation

@timcadman

@timcadman timcadman commented Sep 14, 2026

Copy link
Copy Markdown
Contributor

What's changed

  • Separated Azure and git-actions Armadillo docker compose so new flow doesn't break Azure
  • Load dsBaseClient in Lintr to avoid false positive
  • Show full unit test error messages in git-actions
  • In summary table show code cov for this branch, not whole repo

@timcadman
timcadman changed the base branch from v6.3.6-dev to v7.0-dev September 14, 2026 13:25
@github-actions

github-actions Bot commented Sep 14, 2026

Copy link
Copy Markdown
❌ 1 of 5 checks failed
CheckResult
Devtools checks✅ passed
Code quality✅ 0 new findings (package total: 2132)
Armadillo unit tests[ FAIL 0 | WARN 0 | SKIP 27 | PASS 11076 ]
Opal unit tests[ FAIL 1 | WARN 0 | SKIP 27 | PASS 11097 ]
Test coverageℹ️ no coverable lines changed (project: 60.9%)

Tested against dsBase versions:
Armadillo: 7.0.0.9000
Opal: 7.0.0.9000

Logs: Devtools checks · Code quality · Armadillo unit tests · Opal unit tests · Codecov

@codecov-commenter

codecov-commenter commented Sep 14, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 60.87%. Comparing base (9937412) to head (23c0d4a).

Additional details and impacted files
@@            Coverage Diff            @@
##           v7.0-dev     #703   +/-   ##
=========================================
  Coverage     60.87%   60.87%           
=========================================
  Files           142      142           
  Lines          6365     6365           
=========================================
  Hits           3875     3875           
  Misses         2490     2490           
Flag Coverage Δ
armadillo-arg 18.00% <ø> (ø)
armadillo-misc 15.41% <ø> (ø)
armadillo-perf-1 4.16% <ø> (ø)
armadillo-perf-2 12.64% <ø> (ø)
armadillo-perf-3 6.03% <ø> (ø)
armadillo-smk-1 28.67% <ø> (ø)
armadillo-smk-2 37.86% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@StuartWheater
StuartWheater self-requested a review September 15, 2026 11:08

@StuartWheater StuartWheater left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Is the failure of "Armadillo Report" job's task "Compute results & write summary" also "passed" significant?
  • This doesn't appear to be the originating failure but this "reporting" job is the only one which fails, not the source task. Is this correct?

@timcadman

Copy link
Copy Markdown
Contributor Author
  • Is the failure of "Armadillo Report" job's task "Compute results & write summary" also "passed" significant?
  • This doesn't appear to be the originating failure but this "reporting" job is the only one which fails, not the source task. Is this correct?

Good observations Stuart, thanks. So the 'Armadillo report' failure means one or more Armadillo tests failed (same for opal). But I agree that ideally you would see a failure on that test file too. I will have a look and ask for a re-review

@StuartWheater
StuartWheater self-requested a review September 15, 2026 12:54

@StuartWheater StuartWheater left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The generated reports the behavior of test.

  • (The results of "lint" test are worrying)

@timcadman
timcadman merged commit e3221f5 into v7.0-dev Sep 15, 2026
20 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants