Update with current v7.0-dev - #695
Open
StuartWheater wants to merge 148 commits into
Open
StuartWheater wants to merge 148 commits into
StuartWheater wants to merge 148 commits into
Conversation
⏳ 3 of 5 checks reported so far
Tested against Logs: Devtools checks · pending · Armadillo unit tests · Opal unit tests · Codecov |
⏳ 0 of 5 checks reported so far
Tested against Logs: pending · pending · pending · pending · pending |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
There was a problem hiding this comment.
lintr found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## v7.0-dev_perf-profile-update #695 +/- ##
===============================================================
Coverage ? 61.16%
===============================================================
Files ? 142
Lines ? 6120
Branches ? 0
===============================================================
Hits ? 3743
Misses ? 2377
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Update of 'ds.Boole' perf results
Chore/fix ci
…factor/perf-batch-8
| expect_length(res.errors, 3) | ||
| expect_match(res.errors$sim1, "The server-side object must be of type factor. 'D\\$LAB_TSC' is type numeric.") | ||
| expect_match(res.errors$sim2, "The server-side object must be of type factor. 'D\\$LAB_TSC' is type numeric.") | ||
| expect_match(res.errors$sim3, "The server-side object must be of type factor. 'D\\$LAB_TSC' is type numeric.") |
|
|
||
| expect_length(res.errors, 3) | ||
| expect_match(res.errors$sim1, "The server-side object must be of type factor. 'D\\$LAB_TSC' is type numeric.") | ||
| expect_match(res.errors$sim2, "The server-side object must be of type factor. 'D\\$LAB_TSC' is type numeric.") |
| res.errors <- DSI::datashield.errors() | ||
|
|
||
| expect_length(res.errors, 3) | ||
| expect_match(res.errors$sim1, "The server-side object must be of type factor. 'D\\$LAB_TSC' is type numeric.") |
| # check that the new object has been created and display a message accordingly | ||
| finalcheck <- isAssigned(datasources, newobj) | ||
| calltext <- call("changeRefGroupDS", x, ref, reorderByRef) | ||
| DSI::datashield.assign(datasources, newobj, calltext) |
…lient into refactor/perf-batch-8
Refactor/perf batch 8
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.