Conversation
Ford544
force-pushed
the
bazel-aspect-rules
branch
6 times, most recently
from
September 30, 2026 13:07
ad0efb1 to
7692805
Compare
Ford544
force-pushed
the
bazel-aspect-rules
branch
2 times, most recently
from
October 1, 2026 12:16
98c826c to
43f765d
Compare
Ford544
force-pushed
the
bazel-aspect-rules
branch
from
October 1, 2026 12:37
43f765d to
b0ecca5
Compare
Collaborator
|
Please convert this to PR when it is ready for review. |
Ford544
marked this pull request as ready for review
October 1, 2026 12:54
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates the bazel toolchain and migrates the package manager (adapting the changes from #2206 ):
Package Comparison (
mainvsbazel-aspect-rules)@dataform/core@dataform/clipackage.jsonresolutions(inherited from root package.json) changed forpnpm: stripped**/and@google-cloud/storage/**/glob prefixes from keys, and bumpedprotobufjsresolution from^7.0.0to^7.6.5. All other fields are identical.resolutionsdiff as@dataform/core. All other fields (includingdependencies) are identical."main": "bundle.js"inpackage.json; bundler entry point index.ts and identical exported keys)."main": "bundle.js"and"bin": {"dataform": "bundle.js"}inpackage.json; bundler entry points index.ts and worker.ts).bundle.jsformatlibraryTarget: "commonjs-module"CommonJS bundle from CommonJSts_libraryoutput).ts_libraryoutputesm/index.jsinto a CommonJSbundle.jswithformat = "cjs"inpkg_bundle, same asmain)..d.tsfilesbundle.d.tshas 13 top-level type aliases emitted astypeinstead ofdeclare typeand minor tuple indentation formatting; all types and exports are identical)..d.tsfiles in package).Compilation validation:
Compiled a sample Dataform project containing sqlx and js actions, a yaml action spec and a js include using the published version 3.0.71 and the current build - resulting json verified to be identical.