fix(dashboard): isolate self-host behavior from hosted deployments - #825
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: ASSERTIVE Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
The latest updates on your projects. Learn more about Unkey Deploy
|
|
@greptileai review this |
|
|
@greptileai review this Please review final head 7ac621d. The last two commits only tighten CSP regression assertions. The replies on the three hosted-behavior findings cite the original pre-self-host code and explain the explicit requirement to preserve hosted output; please assess those reasons alongside any remaining defects. |
Summary
Keep the self-host setup changes behind
SELFHOST=true. With the flag absent or false, restore the previous hosted auth cookies and verification emails, alarm sender, registration flow, generated setup snippets, AI setup prompt, and security headers.Move the existing boolean parser into a side-effect-free export and use it for the new mode checks. Checking
SELFHOSTno longer initializes unrelated URL configuration in Redis, billing, telemetry, or process startup.Validation
SELFHOSTabsent, false, and true; hosted email/cookie differences were reproduced before the fixes.Scope
Runtime isolation only. Independent init-image publishing landed in #824. No dependency on an unmerged PR. #790 is adjacent to billing resolution; this PR changes its boolean import only and does not alter the hosted billing fallback. No production deployment or image publication is included.
AI-assisted implementation and review under the maintainer workflow.
Summary by cubic
Isolates self-host configuration behind
SELFHOST=trueso hosted deployments keep their existing behavior. WithSELFHOSTunset or false, restores hosted auth cookies and verification emails, alarm sender, registration flow, generated setup snippets, AI setup prompt, and security headers.Details
readBooleanEnvto@databuddy/env/booleanso checking the mode doesn't initialize unrelated URL config.SELFHOSTabsent, false, and true, including CSP origin membership checks.Written for commit 7ac621d. Summary will update on new commits.