Skip to content

fix(dashboard): include every field in link update previews - #821

Merged
izadoesdev merged 3 commits into
stagingfrom
codex/agent-link-previews
Sep 18, 2026
Merged

izadoesdev merged 3 commits into
stagingfrom
codex/agent-link-previews

Conversation

@izadoesdev

@izadoesdev izadoesdev commented Sep 17, 2026

Copy link
Copy Markdown
Member

Link-update previews omitted expired redirects and social-preview fields, and compared expiration timestamps as dates. Those updates could display "No changes detected" before applying a mutation. Build the update payload once and reuse it for the preview, mutation, and success receipt, preserving full timestamps, null clears, and resolved folder IDs. Empty updates do not write or request confirmation.

This fixes the native link tools used by Slack and dashboard agents. The external MCP server's separate wrapper already returns its proposed payload. The existing conversational confirmation contract remains unchanged; this does not bind approval to a stored payload.

Validation: 39 focused link/catalog/MCP/query tests, 974 AI tests, 95 Slack tests, root lint, all 33 typecheck tasks, and all 29 pre-push test tasks passed. Regression coverage checks exact mutation inputs, all supported update fields, same-day expiration changes, null clears, empty updates, and rejection of invalid folders or incompatible deep links. The AI suite skips 33 integration tests requiring external services. Independently reviewed.

Independent of #818 and #820, which touch separate files. No migrations, new dependencies, environment variables, or user setup. Maintainer-directed, AI-assisted implementation and review.

@vercel

vercel Bot commented Sep 17, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
databuddy-status Ready Ready Preview Sep 18, 2026 8:25am UTC
2 Skipped Deployments
Project Deployment Actions Updated
dashboard Skipped Skipped Sep 18, 2026 8:25am UTC
documentation Skipped Skipped Sep 18, 2026 8:25am UTC

@coderabbitai

coderabbitai Bot commented Sep 17, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: ASSERTIVE

Plan: Advanced

Run ID: bbe035d1-9bbe-4b46-9094-4bdb7559407e

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@unkey-deploy

unkey-deploy Bot commented Sep 18, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Unkey Deploy

Name Status Preview Inspect Updated (UTC)
links (preview) Ready Visit Preview Inspect Sep 18, 2026 8:25am

@greptile-apps

greptile-apps Bot commented Sep 18, 2026

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 4/5

The production change appears behaviorally sound, but the explicit repository prohibition against adding mock data must be satisfied before merging.

Findings

  1. P2 Mock data violates rules

Summary

The PR makes link-update previews, mutations, and success receipts share the same normalized update payload.

  • Includes every supported update field, exact timestamps, explicit null clears, and resolved folder IDs in previews.
  • Avoids confirmation requests and mutations when no updates are supplied.
  • Adds parameterized regression coverage for previews, mutations, empty updates, invalid folders, and incompatible deep links.
  • The previous namespace-import and awaited-loop findings are fixed in the current test code.

Reviews (2) · Last reviewed commit: "test(dashboard): isolate link update pre..."

Comment thread packages/ai/src/ai/tools/links.test.ts
Comment thread packages/ai/src/ai/tools/links.test.ts
Comment thread packages/ai/src/ai/tools/links.test.ts
@izadoesdev
izadoesdev merged commit 7f7aa08 into staging Sep 18, 2026
@izadoesdev
izadoesdev deleted the codex/agent-link-previews branch September 18, 2026 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant