Skip to content

fix(dashboard): dismiss persisted business context generation errors - #810

Merged
izadoesdev merged 2 commits into
stagingfrom
codex/business-context-error-dismissal
Sep 16, 2026
Merged

izadoesdev merged 2 commits into
stagingfrom
codex/business-context-error-dismissal

Conversation

@izadoesdev

@izadoesdev izadoesdev commented Sep 16, 2026

Copy link
Copy Markdown
Member

A failed or timed-out business-context generation stayed visible on every refresh with no way to acknowledge it. Add a dismiss action beside the error that clears that generation through the existing ID-scoped cancel mutation and preserves the saved brief and unsaved local edits.

The server already protects newer generations from an older cancellation. Dismissal requires edit permission only and remains available without generation credits, working AI configuration, or the original source website. Billing/setup guidance stays visible. A failed dismiss request keeps the error available for retry; no new backend endpoint, storage, or dependency is required.

Validation: root lint and all 33 workspace typecheck tasks passed. All 29 business-context/measurement browser regressions passed with zero retries. The new case reproduced the missing dismissal on the prior UI and verifies failed-request recovery, durable dismissal, preservation of unsaved brief/team edits, and visibility of later failures. Desktop and mobile screenshots inspected.

Follow-up to #809. Related context work: #751; no dependency on an unmerged branch. This changes only business-context failure acknowledgement. AI-assisted implementation and review.

@vercel

vercel Bot commented Sep 16, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
dashboard Ready Ready Preview Sep 16, 2026 11:26am UTC
databuddy-status Ready Ready Preview Sep 16, 2026 11:26am UTC
1 Skipped Deployment
Project Deployment Actions Updated
documentation Skipped Skipped Sep 16, 2026 11:26am UTC

@coderabbitai

coderabbitai Bot commented Sep 16, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: ASSERTIVE

Plan: Advanced

Run ID: d1838bd4-6a50-4b4d-8342-e16d307c5ce2

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@greptile-apps

greptile-apps Bot commented Sep 16, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This follow-up fixes the earlier access-gating problem by making persisted generation failures dismissible for any editor, independently of eligibility to begin another AI generation.

  • Derives the visible failed generation independently of generation-access status.
  • Keeps dismissal inside the existing edit-permission and generation-ID boundaries.
  • Adds regressions for credit, availability, and configuration failure states while verifying unsaved draft preservation.
  • The previous finding was manually resolved after the implementation and tests addressed it.

Confidence Score: 5/5

The PR appears safe to merge; the prior dismissal-access defect is fixed without exposing cancellation beyond users with organization update permission.

Editors can now dismiss a persisted failed generation regardless of credit or AI-configuration status, while active generation state, ID-scoped cancellation, local drafts, client permission checks, and server authorization remain intact. The previous thread was manually resolved without explanation.

Important Files Changed

Filename Overview
apps/dashboard/app/(main)/organizations/components/business-context-editor.tsx Separates persisted failure acknowledgement from generation eligibility while retaining edit-permission and in-flight-generation guards.
apps/dashboard/test/e2e/specs/regressions/business-context.spec.ts Covers dismissal across non-allowed generation-access states and verifies that local edits and later failures remain correct.

Reviews (2): Last reviewed commit: "fix(dashboard): allow failure dismissal ..." | Re-trigger Greptile

Comment thread apps/dashboard/app/(main)/organizations/components/business-context-editor.tsx Outdated
@izadoesdev
izadoesdev marked this pull request as draft September 16, 2026 11:22
@unkey-deploy

unkey-deploy Bot commented Sep 16, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Unkey Deploy

Name Status Preview Inspect Updated (UTC)
links (preview) Ready Visit Preview Inspect Sep 16, 2026 11:25am

@izadoesdev
izadoesdev marked this pull request as ready for review September 16, 2026 11:25
@izadoesdev
izadoesdev merged commit 4ae9023 into staging Sep 16, 2026
16 checks passed
@izadoesdev
izadoesdev deleted the codex/business-context-error-dismissal branch September 16, 2026 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant