fix(dashboard): dismiss persisted business context generation errors - #810
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: ASSERTIVE Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Greptile SummaryThis follow-up fixes the earlier access-gating problem by making persisted generation failures dismissible for any editor, independently of eligibility to begin another AI generation.
Confidence Score: 5/5The PR appears safe to merge; the prior dismissal-access defect is fixed without exposing cancellation beyond users with organization update permission. Editors can now dismiss a persisted failed generation regardless of credit or AI-configuration status, while active generation state, ID-scoped cancellation, local drafts, client permission checks, and server authorization remain intact. The previous thread was manually resolved without explanation. Important Files Changed
Reviews (2): Last reviewed commit: "fix(dashboard): allow failure dismissal ..." | Re-trigger Greptile |
|
The latest updates on your projects. Learn more about Unkey Deploy
|
A failed or timed-out business-context generation stayed visible on every refresh with no way to acknowledge it. Add a dismiss action beside the error that clears that generation through the existing ID-scoped cancel mutation and preserves the saved brief and unsaved local edits.
The server already protects newer generations from an older cancellation. Dismissal requires edit permission only and remains available without generation credits, working AI configuration, or the original source website. Billing/setup guidance stays visible. A failed dismiss request keeps the error available for retry; no new backend endpoint, storage, or dependency is required.
Validation: root lint and all 33 workspace typecheck tasks passed. All 29 business-context/measurement browser regressions passed with zero retries. The new case reproduced the missing dismissal on the prior UI and verifies failed-request recovery, durable dismissal, preservation of unsaved brief/team edits, and visibility of later failures. Desktop and mobile screenshots inspected.
Follow-up to #809. Related context work: #751; no dependency on an unmerged branch. This changes only business-context failure acknowledgement. AI-assisted implementation and review.