refactor(dashboard): remove unused billing surfaces and types - #795
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: ASSERTIVE Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
Greptile SummaryThis PR simplifies dashboard billing internals by removing unused hook and context APIs, eliminating duplicate customer and payment-method wrappers, and consuming the existing customer data directly.
Confidence Score: 5/5The PR appears safe to merge with no actionable correctness, security, or repository-rule issues identified. All removed surfaces have no remaining repository consumers, and the active cancellation, payment-method, history, portal, and feature-access paths retain their prior behavior. Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart LR
CustomerHook[useCustomer] --> BillingData[useBillingData]
BillingData --> BillingPage[Billing page]
BillingData --> HistoryPage[Billing history]
BillingPage --> Card[PaymentMethodRow card fields]
BillingHook[useBilling] --> Cancellation[Cancellation confirmation]
BillingHook --> Portal[Customer portal]
BillingProvider[Billing provider] --> Access[Feature and usage access]
Reviews (1): Last reviewed commit: "refactor(dashboard): remove unused billi..." | Re-trigger Greptile |
Billing exposed unused upgrade/cancellation handlers, loading state, context methods, and duplicate customer/type wrappers. Remove those unused surfaces, read the existing customer value directly in history, and type only the four card fields the payment row renders. Delete the single-consumer payment-method type file. Net reduction: 84 lines across 5 files.
Cancellation confirmation, the dialog's pending guard, feedback, refetch, billing portal, purchase flow, feature gates, and pricing retain their behavior.
Validation: root lint, all 33 type/build tasks, all 27 test tasks, and 70 focused billing tests pass. Five synthetic cancellation/portal scenarios match before and after; six payment-card cases render exactly the same HTML. Independent final diff review found no issues. Checks used inline code and mocks, with no new files or live provider calls.
Scope: dashboard billing internals only. No dependency or file overlap with open RPC billing PR #790.