Skip to content

Add doctest coverage to python scripts - #6403

Open
janniklasrose wants to merge 1 commit into
janniklasrose/tools-py-doctestfrom
janniklasrose/doctest-coverage
Open

Add doctest coverage to python scripts#6403
janniklasrose wants to merge 1 commit into
janniklasrose/tools-py-doctestfrom
janniklasrose/doctest-coverage

Conversation

@janniklasrose

@janniklasrose janniklasrose commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

Changes

Add doctest coverage. No script behaviour changes.

Stacked on #6402

Why

Codify script behaviour

Tests

task test-doctest passes

Substantially increase doctest coverage across tools/*.py and
bundle/direct/tools/*.py (the files exercised by the test-doctest task),
from ~20 to ~200 doctests. Coverage targets pure, deterministic
functions (parsing, formatting, validation, data shaping); I/O-only
scripts are left untouched. A few pure helpers were extracted from
larger functions to make their logic testable without changing behavior.

Co-authored-by: Isaac <no-reply@databricks.com>
@janniklasrose
janniklasrose changed the base branch from main to janniklasrose/tools-py-doctest August 27, 2026 15:58
@github-actions

Copy link
Copy Markdown
Contributor

Approval status: pending

/bundle/ - needs approval

Files: bundle/direct/tools/generate_apitypes.py, bundle/direct/tools/generate_resources.py
Suggested: @denik
Also eligible: @pietern, @andrewnester, @lennartkats-db, @shreyas-goenka, @anton-107

General files (require maintainer)

10 files changed
Based on git history:

  • @denik -- recent work in tools/, bundle/direct/tools/

Any maintainer (@andrewnester, @anton-107, @denik, @pietern, @shreyas-goenka, @simonfaltum, @renaudhartert-db, @lennartkats-db, @rugpanov, @rclarey) can approve all areas.
See OWNERS for ownership rules.

@eng-dev-ecosystem-bot

Copy link
Copy Markdown
Collaborator

Integration test report

Commit: d8d0119

Run: 33090760331

Env 💚​RECOVERED 🙈​SKIP ✅​pass 🙈​skip Time
💚​ aws linux 1 1 274 1194 4:03
💚​ aws windows 1 1 276 1192 3:55
💚​ azure linux 1 1 273 1194 4:11
💚​ azure windows 1 1 275 1192 4:37
💚​ gcp linux 1 1 274 1194 4:38
💚​ gcp windows 1 1 276 1192 3:32
Test Name aws linux aws windows azure linux azure windows gcp linux gcp windows
💚​ TestAccept 💚​R 💚​R 💚​R 💚​R 💚​R 💚​R
🙈​ TestAccept/ssh/connection 🙈​S 🙈​S 🙈​S 🙈​S 🙈​S 🙈​S
Top 3 slowest tests (at least 2 minutes):
duration env testname
4:34 azure windows TestAccept
3:51 aws windows TestAccept
3:29 gcp windows TestAccept

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants