Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion packages/core-db/dump.ts
Original file line number Diff line number Diff line change
Expand Up @@ -20,9 +20,11 @@ import { APP_ROLE } from "./schema";
function restorable(dump: string): string {
// `pg_dump` brackets its output in `\restrict` / `\unrestrict`, which only psql reads.
const sql = dump.replace(/^\\(?:un)?restrict\b.*\r?\n?/gm, "");
// The body stops at the statement's `;`. A body that may run on would let a table with no
// `INHERITS` (`_ag_label_vertex` itself) match through to the next table's clause and hide it.
const arity = new Map<string, number>();
for (const m of sql.matchAll(
/^CREATE TABLE (\S+) \([\s\S]*?\)\nINHERITS \(\S+\._ag_label_(vertex|edge)\);/gm,
/^CREATE TABLE (\S+) \([^;]*\)\nINHERITS \(\S+\._ag_label_(vertex|edge)\);/gm,
))
arity.set(m[1]!, m[2] === "vertex" ? 1 : 3);
const graphid = (literal: string): string => {
Expand Down
51 changes: 51 additions & 0 deletions tests/persistence/dump-restore.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -68,3 +68,54 @@ test("dump then restore gives back the graph, and the restored graph takes a wri
rmSync(target, { recursive: true, force: true });
}
}, 60_000);

test("every graph label comes back, including the first vertex and edge label in the dump", async () => {
// `pg_dump` orders tables by name, so `Artefact` directly follows `_ag_label_vertex` and
// `ABOUT` directly follows `_ag_label_edge`: the two tables whose rows were left unrewritten.
const source = mkdtempSync(join(tmpdir(), "labkit-dump-src-"));
const target = mkdtempSync(join(tmpdir(), "labkit-dump-dst-"));
try {
let sql: string;
const handles: string[] = [];
const before = new Map<string, unknown>();
const from = await connectScratch(source);
try {
const ctx = await resolveTenantContext(from.db, from.tx, "labkit");
const graph = new TenantGraph(ctx, from.db, from.tx);
const artefact = await graph.createNode("Artefact", {
kind: "observations",
logical_name: "runs.parquet",
});
const claim = await graph.createNode("Claim", { name: "the dump comes back" });
const verdict = await graph.createNode("CriterionEvaluation", {
value: "it does",
outcome: "pass",
evaluated_at: "2026-09-22T00:00:00.000Z",
});
await graph.createEdge(verdict.natural_id, "ABOUT", claim.natural_id);
handles.push(artefact.natural_id, claim.natural_id, verdict.natural_id);
for (const id of handles) before.set(id, await graph.entityAsHal(id, 1));
sql = await dumpSql(from);
} finally {
await from.close();
}

expect(sql).toContain('INSERT INTO labkit_t1."Artefact" VALUES (ag_catalog._graphid(');
expect(sql).toContain('INSERT INTO labkit_t1."ABOUT" VALUES (ag_catalog._graphid(');
expect(sql).not.toMatch(/^INSERT INTO labkit_t1\."[^"]+" VALUES \('\d+'/m);

await restoreInto(join(target, "pglite"), sql);

const to = await connectScratch(target);
try {
const ctx = await resolveTenantContext(to.db, to.tx, "labkit");
const graph = new TenantGraph(ctx, to.db, to.tx);
for (const id of handles) expect(await graph.entityAsHal(id, 1)).toEqual(before.get(id));
} finally {
await to.close();
}
} finally {
rmSync(source, { recursive: true, force: true });
rmSync(target, { recursive: true, force: true });
}
}, 60_000);
Loading