An expired provider login keeps its identity and asks for a Reconnect - #408
Open
czpython wants to merge 1 commit into
Open
An expired provider login keeps its identity and asks for a Reconnect#408czpython wants to merge 1 commit into
czpython wants to merge 1 commit into
Conversation
PR #273 made an expired credential read as not connected on the wire, but the provider row keyed identity, Disconnect, and the button label on that flag alone, so an expired login rendered like no login at all: no email, no expiry, a first-time Connect. The row now distinguishes a missing login from an expired one: Expired, the account email, the past expiry, Disconnect, and Reconnect. Refs #278 Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #273 made an expired credential read as not connected on the wire, but the provider row keyed identity, Disconnect, and the button label on that flag alone. An expired login rendered like no login at all: no email, no expiry date, and a first-time Connect button.
The row now distinguishes a missing login from an expired one. An expired login shows Expired, the account email,
token expired <date>, Disconnect, and Reconnect. Only a missing login shows Connect.Refs #278. The "alert me when the token expires" half of that issue is still open.
Gates:
npm run lint, the two affected test files, andnpm run buildpass.🤖 Generated with Claude Code