demo: drop the extra type-YES gate on menstrual write options

[cyberjunky]

Summary

The five menstrual write menu options (#432) were the only writes in demo.py that required typing a literal YES to proceed — every other write (delete_weigh_in, create_gear, set_activity_name, set_blood_pressure, etc.) just takes the input directly, some with a 'q' to cancel. Removed _confirm_menstrual_write() and its five call sites so these match the rest of the demo, and updated the menu descriptions from (writes; type YES) to the existing (interactive) convention used everywhere else.

Test plan

• python -m pytest -q (399 passed)
• ruff check / ruff format --check / mypy all clean
• Ran all 5 entry functions end-to-end against a fake API — confirmed each runs straight through with no extra prompt

Summary by CodeRabbit

• Changes
  • Simplified menstrual-tracking interactions by removing the requirement to type “YES” before saving updates.
  • Updated menu descriptions to reflect the revised interactive flow.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Advanced

Run ID: d63d7536-fa99-445e-a171-1ef8f4beaa23

📥 Commits

Reviewing files that changed from the base of the PR and between 43b0b69 and 954a2d9.

📒 Files selected for processing (1)

• demo.py

Included review availability: Your plan provides up to 8 included reviews per hour; 6 remain after this review.

---

Walkthrough

The menstrual write flow in demo.py no longer requires typed YES confirmation. Five entry points proceed directly, and their menu descriptions now identify them as interactive options.

Changes

Menstrual write flow

Layer / File(s)	Summary
Remove menstrual write confirmation demo.py	The shared confirmation helper and its five call-site gates were removed. The five menu descriptions were reworded from requiring YES to being interactive.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix

Suggested reviewers: tshogx

Merge Risk: ⚪ Minimal · up to 954a2

The change implements the stated interaction update, with existing mutation validation retained; it is ready to merge.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and concisely describes the main change: removing the extra typed-YES confirmation gate from menstrual write options.
Docstring Coverage	✅ Passed	Docstring coverage is 85.71% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 7 functions across 1 files.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

📝 Generate docstrings

• Commit to this branch
• Create a new PR

🧪 Generate unit tests (beta)

• Commit to this branch
• Create a new PR

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}