Add first zig scope facet by Antman261 · Pull Request #3111 · cursorless-dev/cursorless

Antman261 · 2025-11-27T08:58:12Z

First slice of zig working end to end.

Let me know if there is anything I should change, e.g. should I make the query less specific? I have never used tree-sitter queries before

Co-authored-by: Andreas Arvidsson <andreas.arvidsson87@gmail.com>

AndreasArvidsson

I've gone through all your new tests and left comments. Please use typescript as a reference language to help you figure out the correct ranges. We do have a scope visualizer on the docs page to help you with this:

Per language:
https://www.cursorless.org/docs/user/languages/typescript/

Per scope:
https://www.cursorless.org/docs/contributing/scopes/argumentList/

The tests are also failing which you need have a look at.

AndreasArvidsson · 2025-12-23T02:40:59Z

bbb is missing as a scope

The removal range of aaa is incorrect

The insertion delimiter is incorrect for a multiline argument

Please use another language, eg javascript, as a reference:
https://github.com/cursorless-dev/cursorless/blob/d21522be750a55b70b50ac251300bfd6dd4baace/data/fixtures/scopes/javascript.core/argument/argument.actual.multiLine.scope

AndreasArvidsson · 2025-12-23T02:43:09Z

bbb is missing as a scope

The removal range of aaa is incorrect

The insertion delimiter is incorrect

AndreasArvidsson · 2025-12-23T02:46:19Z

Please include a second argument so we get a separate removal range in this scope test

AndreasArvidsson · 2025-12-23T02:47:20Z

+  >-----<
+0| foo();
+
+[Insertion delimiter] = " "


The insertion delimiter should be an empty string

AndreasArvidsson · 2025-12-23T02:47:51Z

+  >-------------<
+0| foo(aaa, bbb);
+
+[Insertion delimiter] = " "


The insertion delimiter should be ", "

AndreasArvidsson · 2025-12-23T03:03:09Z

+
+[#3 Removal] = 0:14-0:23
+                >---------<
+0| fn foo(aaa: u8, bbb: u8) void {}


Same problem here

AndreasArvidsson · 2025-12-23T03:03:37Z

@@ -0,0 +1,62 @@
+fn foo(aaa: u8, bbb: u8) void {}


Please remove the arguments for this tests. Now the file is unnecessarily complicated.

AndreasArvidsson · 2025-12-23T03:05:16Z

+
+[Removal] = 0:11-0:14
+             >---<
+0| const foo: u8 = 0;


Removal range should be : u8

cursorless/data/fixtures/scopes/typescript.core/type/type.variable2.scope

Line 10 in d21522b

0| const foo: number = 0;

AndreasArvidsson · 2025-12-23T03:06:12Z

@@ -0,0 +1,20 @@
+const foo = "bar";


Assignment should be assigning a value to an already existing variable. Please rename this file to value.variable

AndreasArvidsson · 2025-12-23T03:07:03Z

+
+[Removal] = 0:11-0:17
+             >------<
+0| const foo = "bar";


Removal range should be = "bar"

cursorless/data/fixtures/scopes/javascript.core/value/value.variable.scope

Line 10 in d21522b

0| const foo = 0;

phillco · 2026-02-09T14:07:34Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: ed6c426bb2

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector · 2026-02-09T14:12:32Z

+foo(
+    aaa, 
+    bbb
+);


Use a function declaration for formal list fixture

This fixture is named argumentList.formal.multiLine, but the sample code is a call expression (foo(...)) rather than a function declaration. The Zig query for formal argument lists only matches function_declaration (parameters), so this fixture won’t exercise the intended scope and can let regressions slip or produce misleading docs/tests for formal lists. Consider changing the snippet to a fn foo(... ) declaration so the fixture actually validates the formal list behavior.

Useful? React with 👍 / 👎.

chatgpt-codex-connector · 2026-02-09T14:12:32Z

+[#2 Content] = 0:12-0:14
+              >--<
+0| fn foo(aaa: u8, bbb: u8) void {}


Don’t include parameter types in return-type fixture

The type.return fixture includes additional captures for the parameter types ([#2 Content] = 0:12-0:14, etc.). That makes the fixture assert that parameter types are part of the return-type scope, which contradicts the facet’s intent and will either fail tests or mask a broken return-type query by validating the wrong targets. The fixture should only contain the return type range.

Useful? React with 👍 / 👎.

Antman261 · 2026-02-13T13:51:00Z

Sorry I haven't gotten to this yet — life threw a few curveballs at me at once. I really appreciate the thorough reviews and hopefully I'll be able to get back to this and wrap it up soon 🙏

AndreasArvidsson · 2026-02-13T13:58:34Z

No stress. Let's revisit whenever you have the time.

chatgpt-codex-connector · 2026-09-06T03:32:42Z

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review	Status	Commit	Review trigger
📝 Code Review	✅ Completed 2026-09-06T03:39:19.791549Z	`0c3428d`	New commits

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 0c3428d978

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-09-06T03:39:15Z

+(call_expression
+  function: (_) @functionCallee
+  (arguments
+    (_) @argumentOrParameter


Configure delimiters on the captured actual arguments

The first call_expression match captures each actual argument without assigning an insertion delimiter, so it wins over the later delimiter-aware match; the committed single-line fixture confirms the resulting delimiter is " " rather than ", ". Consequently, inserting or bringing an argument beside aaa in foo(aaa, bbb) produces invalid Zig such as foo(aaa newArg, bbb), and multiline calls have the same problem. Capture actual arguments only through the delimiter-configured pattern (using the arguments node as its multiline condition).

AGENTS.md reference: AGENTS.md:L13-L14

Useful? React with 👍 / 👎.

chatgpt-codex-connector · 2026-09-06T03:39:15Z

@@ -0,0 +1,10 @@
+foo(aaa, bbb);


Put the Zig fixtures in the discovered scope-test directory

All newly added Zig fixtures are under data/fixtures/scopes, but the scope-test discovery code reads only resources/fixtures/scopes; a repository-wide inspection found no discovery path for this new data directory. As a result, pnpm test silently runs none of these 21 fixtures, so query regressions—including the incorrect delimiter currently recorded by these files—are not checked.

AGENTS.md reference: AGENTS.md:L13-L13

Useful? React with 👍 / 👎.

chatgpt-codex-connector · 2026-09-06T03:39:15Z

+
+const { supported, notApplicable, unsupported } = ScopeSupportFacetLevel;
+
+export const zigScopeSupport: LanguageScopeSupportFacetMap = {


Register the Zig support table with its consumers

This exports a Zig support table but never imports it into languageScopeSupport, and LanguageId/languageReferences also omit zig. Therefore the scope-test recorder cannot offer Zig, the missing-scope documentation excludes it, and moving these fixtures into the discovered directory would make scope coverage fail at getLanguageId("zig"); add Zig to both registries when introducing this table.

AGENTS.md reference: AGENTS.md:L15-L15

Useful? React with 👍 / 👎.

chatgpt-codex-connector · 2026-09-06T03:39:15Z

@@ -0,0 +1,5 @@
+import { Language } from "./components/Language";


Place the Zig language page in the documentation package

This page is added beneath a new packages/cursorless-org-docs tree, while the built documentation and every existing language page are under packages/app-web-docs; a repository-wide search also finds no components/Language module at this import location. The documentation build therefore never includes this Zig page, so it needs to be generated in the actual docs package using that package's existing language-page structure.

AGENTS.md reference: AGENTS.md:L3-L7

Useful? React with 👍 / 👎.

Add first zig scope facet

3cb55ab

Antman261 requested a review from a team as a code owner November 27, 2025 08:58

AndreasArvidsson requested changes Nov 27, 2025

View reviewed changes

Comment thread queries/zig.scm Outdated

Comment thread packages/lib-common/src/scopeSupportFacets/zig.ts

Comment thread packages/lib-common/src/scopeSupportFacets/zig.ts

Comment thread packages/common/src/scopeSupportFacets/zig.ts Outdated

Antman261 and others added 22 commits November 27, 2025 19:16

Update queries/zig.scm

0abea27

Co-authored-by: Andreas Arvidsson <andreas.arvidsson87@gmail.com>

Update packages/common/src/scopeSupportFacets/zig.ts

c2fe2de

Co-authored-by: Andreas Arvidsson <andreas.arvidsson87@gmail.com>

Update packages/common/src/scopeSupportFacets/zig.ts

d56874b

Co-authored-by: Andreas Arvidsson <andreas.arvidsson87@gmail.com>

Merge branch 'main' into main

bef3efe

Apply suggestion from @AndreasArvidsson

1f32c82

Co-authored-by: Andreas Arvidsson <andreas.arvidsson87@gmail.com>

add more scopes and scope tests

94a9433

Merge branch 'main' into main

8eb1fe7

wip: improving zig scm

957ca92

Merge branch 'main' of https://github.com/Antman261/cursorless

05929f9

wip: improve Zig scm

15b273c

Improve scm examples

1c060d3

Update arg list test

69cd67b

wip: add more scope tests

e03a4f6

wip: improving argument iteration and domain

f35dd75

wip: function declaration argument iteration working

35d1442

wip: fix variable declaration type removal of leading ":"

07aed70

Merge branch 'main' into main

f7dfc6f

Remove unsupported arg iteration scopes

3137256

Merge branch 'main' of https://github.com/Antman261/cursorless

55e6843

Remove unsupported scope files

fa4bbcd

Add zig language page to docs

86f322e

Fix bug with argument actual

4d093f3

Antman261 requested a review from AndreasArvidsson December 22, 2025 12:12

Merge branch 'main' into main

80b9512

AndreasArvidsson requested changes Dec 23, 2025

View reviewed changes

Merge branch 'main' into main

ed6c426

chatgpt-codex-connector Bot reviewed Feb 9, 2026

View reviewed changes

Merged with main

af7570d

github-actions Bot added lines/500-999 Pull request changes 500 to 999 lines review/updated-after-changes-requested New commits were pushed after changes were requested labels Sep 6, 2026

Remove language scope supports

0c3428d

chatgpt-codex-connector Bot reviewed Sep 6, 2026

View reviewed changes


		const { supported, notApplicable, unsupported } = ScopeSupportFacetLevel;

		export const zigScopeSupport: LanguageScopeSupportFacetMap = {

		@@ -0,0 +1,5 @@
		import { Language } from "./components/Language";

Uh oh!

Uh oh!

Conversation

Antman261 commented Nov 27, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

AndreasArvidsson left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

phillco commented Feb 9, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot Feb 9, 2026

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector Bot Feb 9, 2026

Choose a reason for hiding this comment

Uh oh!

Antman261 commented Feb 13, 2026

Uh oh!

AndreasArvidsson commented Feb 13, 2026

Uh oh!

chatgpt-codex-connector Bot commented Sep 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codex Review Summary

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot Sep 6, 2026

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector Bot Sep 6, 2026

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector Bot Sep 6, 2026

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector Bot Sep 6, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

chatgpt-codex-connector Bot commented Sep 6, 2026 •

edited

Loading