Skip to content

Add referenced CLABE support - #446

Merged
gmorales96 merged 2 commits into
mainfrom
feat/referenced-clabe
Sep 15, 2026
Merged

gmorales96 merged 2 commits into
mainfrom
feat/referenced-clabe

Conversation

@gmorales96

@gmorales96 gmorales96 commented Sep 15, 2026

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

  • New Features

    • CLABE records now include permitted CURP/RFC and default-status information.
    • CLABE listings can be filtered by permitted CURP/RFC.
    • CLABE creation requires a legal-person ID and permitted CURP/RFC.
  • Changes

    • Additional response fields are safely ignored for improved compatibility.
    • Direct CLABE retrieval is no longer supported; use filtered listing instead.
    • CLABE query parameters are now validated before requests are sent.

@coderabbitai

coderabbitai Bot commented Sep 15, 2026

Copy link
Copy Markdown

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Essentials

Run ID: e0a7a864-6388-44f9-bfbe-a4e931b2ab25

📥 Commits

Reviewing files that changed from the base of the PR and between dcd6e7d and da94931.

📒 Files selected for processing (1)
  • tests/resources/test_clabes.py
💤 Files with no reviewable changes (1)
  • tests/resources/test_clabes.py

Included review availability: 2 reviews are currently available. Your included PR review attempts over the past 7 days set your current allowance at 5 reviews per hour.


Walkthrough

Clabe now validates query and creation inputs, includes CURP/RFC and default-status fields, ignores extra response fields, and no longer supports retrieval. Creation requires legal_person_id and allowed_curp_rfc. Tests and cassettes cover updated creation and filtered listing behavior. The package version and cuenca-validations requirement are updated.

Priority: ⬇️ Low

Estimated code review effort: 3 (Moderate) | ~20 minutes

Change: Feature

Suggested reviewers: alexviquez

Merge Risk: ⚪ Minimal · up to da949

The updated CLABE creation and filtered-listing contracts align with their recorded API interactions, with no identified merge-blocking behavior.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 3 functions across 4 files. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately and concisely describes the main change: adding support for referenced CLABEs.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
  • Fix all pre-merge checks with AI
✨ Finishing Touches 💡 1
📝 Generate docstrings 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/referenced-clabe

Comment @coderabbitai help to get the list of available commands.

@codecov

codecov Bot commented Sep 15, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (a2441ac) to head (da94931).

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #446   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           58        58           
  Lines         1290      1297    +7     
=========================================
+ Hits          1290      1297    +7     
Flag Coverage Δ
unittests 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
cuenca/resources/clabes.py 100.00% <100.00%> (ø)
cuenca/version.py 100.00% <100.00%> (ø)

Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a2441ac...da94931. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@gmorales96
gmorales96 merged commit 8436a25 into main Sep 15, 2026
18 checks passed
@gmorales96
gmorales96 deleted the feat/referenced-clabe branch September 15, 2026 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants