[build] Drop the dead publications workflow, loader, and data - #7
Merged
Merged
Conversation
ctr26
pushed a commit
that referenced
this pull request
Oct 4, 2026
cv-print.css keeps a role heading on the same page as its bullets, so make pdf no longer splits the National Physical Laboratory entry across the break. _config.yml gains url, author, and a real description, so jekyll-seo-tag emits a meta description and canonical link. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01JFVYogXC9MgS2EuFBvrZog
Owner
Author
|
Status after #8, #9 and #11 merged:
Generated by Claude Code |
Nothing loads assets/js/publications.js (the default layout has no script tag for it), assets/data/publications.json fed only that loader and listed Russell as first author of TxPert, and the workflow rewrote a timestamp and pushed an [auto] commit on every push to master. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01JFVYogXC9MgS2EuFBvrZog
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The deleted assets have no remaining references, and the removals are internally consistent.
Review effort: Balanced
Findings: None
What changed in this PR
Removes unused publication-loading infrastructure from the Jekyll portfolio, eliminating stale data and an ineffective automated workflow.
Changes:
- Removed the unused client-side publication loader and JSON dataset.
- Removed the workflow that only refreshed the dataset timestamp.
| File | Description |
|---|---|
assets/js/publications.js |
Removes the unreferenced publication loader. |
assets/data/publications.json |
Removes stale publication data. |
.github/workflows/update-publications.yml |
Removes ineffective publication-update automation. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
ctr26
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Rebuilt on
masterwith only the piece of the original PR that #8, #9 and #11 did not supersede: removing the dead publications machinery..github/workflows/update-publications.ymlrewrote a timestamp and pushed an[auto]commit on every push tomasterand weekly; it never fetched anythingassets/js/publications.jsis loaded by no layout (the Minimadefaultlayout has no script tag for it)assets/data/publications.jsonfed only that loader and listed Russell as first author of TxPertThe CV polish and
_config.ymlSEO metadata from the original PR are already onmastervia #8, #9 and #11.Testing
🤖 Generated with Claude Code
https://claude.ai/code/session_01JFVYogXC9MgS2EuFBvrZog