Conversation
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> (cherry picked from commit 1b25b3a)
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The targeted Chrome print rule correctly addresses the reported page-break issue without affecting the website.
Review effort: Balanced
Findings: None
What changed in this PR
Adds print-only pagination styling so CV role headings stay with their following bullet lists.
Changes:
- Prevents page breaks immediately after paragraphs followed by unordered lists.
| File | Description |
|---|---|
cv-print.css |
Adds the role-heading pagination rule. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
ctr26
pushed a commit
that referenced
this pull request
Oct 4, 2026
cv-print.css keeps a role heading on the same page as its bullets, so make pdf no longer splits the National Physical Laboratory entry across the break. _config.yml gains url, author, and a real description, so jekyll-seo-tag emits a meta description and canonical link. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01JFVYogXC9MgS2EuFBvrZog
Owner
Author
|
Superseded by #11, which carried the same rule ( Generated by Claude Code |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #9. That PR merged at
f3df8e3; this commit (1b25b3a) reached the branch after the merge.Adds one print-only rule to
cv-print.css:p:has(+ ul) { break-after: avoid; }. Without it,make pdfsplits the National Physical Laboratory entry across the page break (heading at the foot of page 1, bullet on page 2). With it, the PDF is still 2 A4 pages and the entry starts page 2 whole. The website itself is unaffected (print CSS only).🤖 Generated with Claude Code