Avoid locale-aware project config sorting on PostgreSQL - #19572
Merged
brandonkelly merged 1 commit intoSep 8, 2026
Merged
Conversation
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Reloading project config on an internal config cache miss orders all stored paths using the database’s default collation. On PostgreSQL with a locale-aware collation, this sort can dominate the reload time and delay both control panel and frontend requests.
On an affected production database containing 38,633 project-config rows, the normal query took approximately 790 ms, compared with 55 ms for the same query ordered by
path COLLATE "C". Most of the original query time was spent sorting.Use PostgreSQL’s bytewise
Ccollation specifically when ordering paths in_loadInternalConfig(). This preserves the parent-before-child ordering needed to reconstruct nested config without paying for language-aware sorting of machine identifiers. The existing config cleanup still applies its natural key sorting afterward.The change requires no schema migration and leaves MySQL ordering unchanged. It targets config-cache misses; it does not imply that every slow request reloads project config.
Related issues
No existing GitHub issue.