Fix #14974: [regression] inline supression does not work with build dir anymore - #8801
Merged
Conversation
glankk
force-pushed
the
14974
branch
2 times, most recently
from
August 19, 2026 20:47
5c37b20 to
a7c4597
Compare
Collaborator
|
There's also #8797 |
Collaborator
Author
|
This PR will address a broader regression caused by the lazy loading of headers, where only the primary source file is considered when using a cached build directory. This causes both hash mismatches and failure to process inline suppression in included files. |
glankk
changed the title
glankk
marked this pull request as ready for review
August 28, 2026 13:24
danmar
reviewed
Aug 28, 2026
Co-authored-by: Daniel Marjamäki <daniel.marjamaki@gmail.com>
danmar
reviewed
Aug 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also fixes #14993.
The hash in the AnalyzerInformation file has been changed from an attribute to a node, this is because the hash is not known at the time the root node is written. An alternative would be to delay writing anything at all until checking is complete.
An
includesnode has been added to the AnalyzerInformation file to keep track of which files were included during the last check, this allows calculating the correct hash and processing inline suppressions before any checking is done.